You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/27 08:01:06 UTC
[GitHub] [yunikorn-site] cdmikechen opened a new pull request #144: [YUNIKORN-1154] Translate YuniKorn Release Procedure to zh-cn
cdmikechen opened a new pull request #144:
URL: https://github.com/apache/yunikorn-site/pull/144
There are two task to do in this PR
- [x] Translate YuniKorn Release Procedure to zh-cn
- [x] Fix some problems in YuniKorn Release Procedure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on pull request #144: [YUNIKORN-1154] Translate YuniKorn Release Procedure to zh-cn
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #144:
URL: https://github.com/apache/yunikorn-site/pull/144#issuecomment-1084195133
I just noticed that we have lost an important update in the English version. YUNIKORN-994 fixed the tagging documentation. That change was not picked up when moving the doc from the release repo to the web site: YUNIKORN-1166 has been filed to fix that. I will create a PR later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on pull request #144: [YUNIKORN-1154] Translate YuniKorn Release Procedure to zh-cn
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #144:
URL: https://github.com/apache/yunikorn-site/pull/144#issuecomment-1084757157
Sorry for the major update to the doc but there were a number of issues that needed to be resolved.
Changes are committed to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] yangwwei commented on a change in pull request #144: [YUNIKORN-1154] Translate YuniKorn Release Procedure to zh-cn
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #144:
URL: https://github.com/apache/yunikorn-site/pull/144#discussion_r836556544
##########
File path: i18n/zh-cn/docusaurus-plugin-content-pages/community/release_procedure.md
##########
@@ -0,0 +1,272 @@
+---
+id: release_procedure
+title: 发布程序
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to you under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+# YuniKorn 发布程序
+
+[发布存储库](https://github.com/apache/yunikorn-release) 包含了 Apache YuniKorn 创建 release（下文统称为发布）的代码和配置。
Review comment:
>Apache YuniKorn 创建 release（下文统称为发布）
Release 是不是可以翻译为 ”发行版” ？
##########
File path: i18n/zh-cn/docusaurus-theme-classic/navbar.json
##########
@@ -28,6 +28,9 @@
},
"item.label.Reporting Issues": {
"message": "报告问题"
+ },
+ "item.label.Release Procedure": {
+ "message": "发布程序"
Review comment:
创建发行版流程
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on a change in pull request #144: [YUNIKORN-1154] Translate YuniKorn Release Procedure to zh-cn
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #144:
URL: https://github.com/apache/yunikorn-site/pull/144#discussion_r835982586
##########
File path: src/pages/community/release_procedure.md
##########
@@ -34,12 +34,13 @@ The instructions and tools obey the ASF [release policy](http://www.apache.org/l
* [Run the release tool](#run-the-release-tool)
* [Create Signature](#create-signature)
* [Create Checksum](#create-checksum)
- * [Upload Release Candidate Artefacts](#upload-release-candidate-artefacts)
+ * [Upload Release Candidate Artifacts](#upload-release-candidate-artifacts)
* [Start Voting Thread](#start-voting-thread)
* [Publish the Release](#publish-the-release)
* [Release Docker images](#release-docker-images)
* [Release Helm Charts](#release-helm-charts)
* [Update the website](#update-the-website)
+ * [Cleanup](#Cleanup)
Review comment:
no capitals in the internal links
##########
File path: src/pages/community/release_procedure.md
##########
@@ -223,7 +225,7 @@ Older releases should be downloaded from the archive directly, not from the rele
The releases need to clean up in two locations:
* Remove the newly released version from the _dev_ area by removing the old release candidate directory.
- For the location see [release candidate location](#Upload-Release-Candidate-Artefacts)
+ For the location see [release candidate location](#Upload-Release-Candidate-Artifacts)
* Remove the non-current release from the _release_ area by removing the old release directory.
For the location see [release location](#Publish-the-Release)
Review comment:
this one needs fixing also: only lower case
##########
File path: src/pages/community/release_procedure.md
##########
@@ -187,7 +189,7 @@ Contrary to the source code tar ball signing, signing the helm charts requires m
The helm package will generate two files:
- helm package: example `yunikorn-0.8.0.tgz`
- provenance or signature file: example `yunikorn-0.8.0.tgz.prov`
-Both files should be attached to the [release in GIT](#Create-the GIT-releases) for the release repository.
+Both files should be attached to the [release in GIT](#Create-the-GIT-releases) for the release repository.
Review comment:
no capitals in the internal links
##########
File path: src/pages/community/release_procedure.md
##########
@@ -223,7 +225,7 @@ Older releases should be downloaded from the archive directly, not from the rele
The releases need to clean up in two locations:
* Remove the newly released version from the _dev_ area by removing the old release candidate directory.
- For the location see [release candidate location](#Upload-Release-Candidate-Artefacts)
+ For the location see [release candidate location](#Upload-Release-Candidate-Artifacts)
Review comment:
links needs fixing: only lower case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] cdmikechen commented on pull request #144: [YUNIKORN-1154] Translate YuniKorn Release Procedure to zh-cn
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on pull request #144:
URL: https://github.com/apache/yunikorn-site/pull/144#issuecomment-1086780468
@wilfred-s @yangwwei
OK~ I'll revise it again in these two days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org