You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lw-lin <gi...@git.apache.org> on 2017/01/17 16:07:34 UTC

[GitHub] spark pull request #16547: [SPARK-19168][Structured Streaming] StateStore sh...

Github user lw-lin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16547#discussion_r96445159
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala ---
    @@ -335,4 +344,67 @@ class StreamingAggregationSuite extends StreamTest with BeforeAndAfterAll {
           CheckLastBatch((90L, 1), (100L, 1), (105L, 1))
         )
       }
    +
    --- End diff --
    
    The idea of this test is injecting a mock state store, which:
    - throw an error in its `commit()` method
    - mark the `aborted` flag in its `abort()` method
    And at the end of the test, we would check if `aborted` is true


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org