[GitHub] [spark] kiszk commented on a change in pull request #24593: [SPARK-27692][SQL] Add new optimizer rule to evaluate the deterministic scala udf only once if all inputs are literals

[GitBox <gi...@apache.org>]

kiszk commented on a change in pull request #24593: [SPARK-27692][SQL] Add new optimizer rule to evaluate the deterministic scala udf only once if all inputs are literals
URL: https://github.com/apache/spark/pull/24593#discussion_r284892526
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
 ##########
 @@ -398,7 +398,7 @@ class FileBasedDataSourceSuite extends QueryTest with SharedSQLContext with Befo
               .contains(errorMessage(format)))
 
             msg = intercept[AnalysisException] {
-              spark.udf.register("testType", () => new NullData())
+              spark.udf.register("testType", udf(() => new NullData()).asNondeterministic())
 
 Review comment:
   It would be good to add a comment as pointed out at [here](https://github.com/apache/spark/pull/24593/files#r283741849).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org