You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/09/02 16:13:22 UTC

[GitHub] carbondata pull request #2675: [CARBONDATA-2901] Fixed JVM crash in Load sce...

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2675#discussion_r214545843
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java ---
    @@ -127,8 +127,11 @@ public UnsafeSortDataRows(SortParameters parameters,
       /**
        * This method will be used to initialize
        */
    -  public void initialize() throws MemoryException, CarbonSortKeyAndGroupByException {
    +  public void initialize() throws MemoryException {
         this.rowPage = createUnsafeRowPage();
    +    if (this.rowPage == null) {
    --- End diff --
    
    No need to check null case here if it initialize fails throw exception no need to check for null


---