You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/11 10:25:18 UTC

[GitHub] [geode] alb3rtobr edited a comment on pull request #5970: GEODE-8877: Configurable membership bind address

alb3rtobr edited a comment on pull request #5970:
URL: https://github.com/apache/geode/pull/5970#issuecomment-777343096


   > I like the cleanup of "gemfire" wording.
   
   the "boy scout rule" :)
   
   > It doesn't look like there is any DirectChannel class testing. Adding a basic test there, would be valuable. I won't block the change for that though...
   
   I will try to add something while I receive more reviews.
   
   Thanks @mhansonp & @rhoughton-pivot  !
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org