[GitHub] wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

[GitBox <gi...@apache.org>]

wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
URL: https://github.com/apache/cloudstack/pull/3077#discussion_r247534718
 
 

 ##########
 File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
 ##########
 @@ -260,4 +173,37 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
         return ip6Vo != null || nicSecondaryIpVO != null;
     }
 
+    @Override
+    public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
+        /**
+         * Calculate the IPv6 Address the Instance will obtain using SLAAC and IPv6 EUI-64
 
 Review comment:
   I think that's a personal thing. I put the comment in there to document that piece of the code, not the method perse.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services