[GitHub] zhaijack commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

[GitBox <gi...@apache.org>]

zhaijack commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split
URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r177306959
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/LocalZooKeeperCacheService.java
 ##########
 @@ -105,6 +108,38 @@ public LocalPolicies deserialize(String path, byte[] content) throws Exception {
 
                 return future;
             }
+
+            @Override
+            public CompletableFuture<Optional<Entry<LocalPolicies, Stat>>> getWithStatAsync(String path) {
 
 Review comment:
   Thanks, Seems a lot of other place call it indirectly, remove it will cause error of BrokerServiceTest/testCreateNamespacePolicy at least. 
   Added it back in latest commit, which removed the duplicated logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services