You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/04/02 16:23:30 UTC
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9884
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
This patch fixes the NullPointerException in SHOW CREATE TABLE for HBase
tables.
Testing:
- Put back hbase-show-create-table.test
- Ran show-create-table end-to-end tests
Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M testdata/workloads/functional-query/queries/QueryTest/hbase-show-create-table.test
M tests/metadata/test_show_create_table.py
3 files changed, 15 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/9884/1
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9884/2/tests/metadata/test_show_create_table.py
File tests/metadata/test_show_create_table.py:
http://gerrit.cloudera.org:8080/#/c/9884/2/tests/metadata/test_show_create_table.py@37
PS2, Line 37: last_modified_by",
: "last_modified_time"]
> Quick question, why are these added now? Don't see them in the show create
They are in some tables.
[localhost:21000] > show create table functional_hbase.alltypes;
Query: show create table functional_hbase.alltypes
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| result |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| CREATE EXTERNAL TABLE functional_hbase.alltypes ( |
| id INT COMMENT 'Add a comment', |
| bigint_col BIGINT, |
| bool_col BOOLEAN, |
| date_string_col STRING, |
| double_col DOUBLE, |
| float_col FLOAT, |
| int_col INT, |
| month INT, |
| smallint_col SMALLINT, |
| string_col STRING, |
| timestamp_col TIMESTAMP, |
| tinyint_col TINYINT, |
| year INT |
| ) |
| STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' |
| WITH SERDEPROPERTIES ('hbase.columns.mapping'=':key,d:bool_col,d:tinyint_col,d:smallint_col,d:int_col,d:bigint_col,d:float_col,d:double_col,d:date_string_col,d:string_col,d:timestamp_col,d:year,d:month', 'serialization.format'='1') |
| TBLPROPERTIES ('hbase.table.name'='functional_hbase.alltypes', 'last_modified_by'='fwijaya', 'last_modified_time'='1522345971', 'storage_handler'='org.apache.hadoop.hive.hbase.HBaseStorageHandler') |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
last_modifed_by and last_modified_time are properties that can change all the time. It's better to ignore those properties.
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 19:30:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:12:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2231/
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 20:17:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
This patch fixes the NullPointerException in SHOW CREATE TABLE for HBase
tables.
Testing:
- Moved the content of back hbase-show-create-table.test to
show-create-table.test
- Ran show-create-table end-to-end tests
Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Reviewed-on: http://gerrit.cloudera.org:8080/9884
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
D testdata/workloads/functional-query/queries/QueryTest/hbase-show-create-table.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M tests/metadata/test_show_create_table.py
4 files changed, 33 insertions(+), 29 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 20:16:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 20:16:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 2:
> Patch Set 1:
>
> I was curious to see if we'd see this anywhere else, and I ran the following against the minicluster. It looked to me that the only other category where "show create table" didn't work has reasonable "this is not supported" messages.
>
> $(for db in $(impala-shell.sh -B --query 'show databases' 2> /dev/null | awk '{ print $1 }'); do for table in $(impala-shell.sh -B --query "show tables in $db" 2> /dev/null); do impala-shell.sh -B --query "show create table $db.$table"; done; done) |& tee /tmp/out
Thanks for the awesome script. I ran your script with my patch and most tables were able to run "show create table" with the exception of those tables that are not supported, i.e INDEX_TABLE, etc.: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/TableLoader.java#L36-L37
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 18:50:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9884/2/tests/metadata/test_show_create_table.py
File tests/metadata/test_show_create_table.py:
http://gerrit.cloudera.org:8080/#/c/9884/2/tests/metadata/test_show_create_table.py@37
PS2, Line 37: last_modified_by",
: "last_modified_time"]
Quick question, why are these added now? Don't see them in the show create output.
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 19:24:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 1:
I was curious to see if we'd see this anywhere else, and I ran the following against the minicluster. It looked to me that the only other category where "show create table" didn't work has reasonable "this is not supported" messages.
$(for db in $(impala-shell.sh -B --query 'show databases' 2> /dev/null | awk '{ print $1 }'); do for table in $(impala-shell.sh -B --query "show tables in $db" 2> /dev/null); do impala-shell.sh -B --query "show create table $db.$table"; done; done) |& tee /tmp/out
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 18:33:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
This patch fixes the NullPointerException in SHOW CREATE TABLE for HBase
tables.
Testing:
- Moved the content of back hbase-show-create-table.test to
show-create-table.test
- Ran show-create-table end-to-end tests
Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
D testdata/workloads/functional-query/queries/QueryTest/hbase-show-create-table.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M tests/metadata/test_show_create_table.py
4 files changed, 33 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/9884/2
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9884/1/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java:
http://gerrit.cloudera.org:8080/#/c/9884/1/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@233
PS1, Line 233: RowFormat rowFormat = RowFormat.fromStorageDescriptor(msTable.getSd());
: HdfsFileFormat format = null;
: HdfsCompression compression = null;
: String inputFormat = msTable.getSd().getInputFormat();
: if (inputFormat != null) {
: format = HdfsFileFormat.fromHdfsInputFormatClass(inputFormat);
: compression = HdfsCompression.fromHdfsInputFormatClass(inputFormat);
: }
I think these things make sense only for an HdfsTable (kudu format is handled below separately). So instead of checking for inputFormat != null, should we do something like
if (table instanceof HdfsTable) {
// check for hdfs related stuff
}
http://gerrit.cloudera.org:8080/#/c/9884/1/testdata/workloads/functional-query/queries/QueryTest/hbase-show-create-table.test
File testdata/workloads/functional-query/queries/QueryTest/hbase-show-create-table.test:
http://gerrit.cloudera.org:8080/#/c/9884/1/testdata/workloads/functional-query/queries/QueryTest/hbase-show-create-table.test@2
PS1, Line 2: ---- QUERY
: SHOW CREATE TABLE functional_hbase.alltypes
: ---- RESULTS
: CREATE EXTERNAL TABLE functional_hbase.alltypes (
: id INT COMMENT 'Add a comment',
: bigint_col BIGINT,
: bool_col BOOLEAN,
: date_string_col STRING,
: double_col DOUBLE,
: float_col FLOAT,
: int_col INT,
: month INT,
: smallint_col SMALLINT,
: string_col STRING,
: timestamp_col TIMESTAMP,
: tinyint_col TINYINT,
: year INT
: )
: STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler'
: WITH SERDEPROPERTIES ('hbase.columns.mapping'=':key,d:bool_col,d:tinyint_col,d:smallint_col,d:int_col,d:bigint_col,d:float_col,d:double_col,d:date_string_col,d:string_col,d:timestamp_col,d:year,d:month',
: 'serialization.format'='1')
: TBLPROPERTIES ('hbase.table.name'='functional_hbase.alltypes',
: 'storage_handler'='org.apache.hadoop.hive.hbase.HBaseStorageHandler')
I think we could merge this with show-create-table.test. Don't think we need a separate file for it.
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 17:09:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9884/2/tests/metadata/test_show_create_table.py
File tests/metadata/test_show_create_table.py:
http://gerrit.cloudera.org:8080/#/c/9884/2/tests/metadata/test_show_create_table.py@37
PS2, Line 37: last_modified_by",
: "last_modified_time"]
> They are in some tables.
cool, I didn't see those for hbase tables in my local cluster. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 20:26:29 +0000
Gerrit-HasComments: Yes