You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/15 13:32:38 UTC
[GitHub] [arrow] pitrou opened a new pull request, #14645: ARROW-18290: [C++] Escape all special chars in URI-encoding
pitrou opened a new pull request, #14645:
URL: https://github.com/apache/arrow/pull/14645
By default, the AWS SDK doesn't URI-escape some special chars such as '='. This works fine with AWS endpoints, but not with some non-AWS S3-compatible endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14645: ARROW-18290: [C++] Escape all special chars in URI-encoding
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14645:
URL: https://github.com/apache/arrow/pull/14645#issuecomment-1315529478
Great, thank you! Will merge then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14645: ARROW-18290: [C++] Escape all special chars in URI-encoding
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14645:
URL: https://github.com/apache/arrow/pull/14645#issuecomment-1315317184
@milesgranger I don't know if you would be able to test this. The fix requires a recent enough AWS SDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14645: ARROW-18290: [C++] Escape all special chars in URI-encoding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14645:
URL: https://github.com/apache/arrow/pull/14645#issuecomment-1315317211
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #14645: ARROW-18290: [C++] Escape all special chars in URI-encoding
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14645:
URL: https://github.com/apache/arrow/pull/14645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14645: ARROW-18290: [C++] Escape all special chars in URI-encoding
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14645:
URL: https://github.com/apache/arrow/pull/14645#issuecomment-1315918957
Benchmark runs are scheduled for baseline = dc7f1ee2cf37f7b00b18bbfa2a94f3925af68668 and contender = a068096d9c561b5bffff7211f8d5288a728c3a9a. a068096d9c561b5bffff7211f8d5288a728c3a9a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c4d7d54ebea644d4b080753ee854fd39...3999b10fff4f423f940d24e2e696137c/)
[Finished :arrow_down:0.14% :arrow_up:0.34%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/757e51b0ec0c432b83d4a5afef199a48...fb64b10ee55a45eebd2037fa60379bdf/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/924aebe69d9342e7821c268cf8713d70...23aba7d9883a44eca95f7e4cbb47bee7/)
[Finished :arrow_down:2.12% :arrow_up:0.18%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/754908ea941041bf86d2499a6d6cfdfa...4c6d8ad7bb034adfbbe5f05d69a3e022/)
Buildkite builds:
[Finished] [`a068096d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1868)
[Finished] [`a068096d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1890)
[Finished] [`a068096d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1857)
[Finished] [`a068096d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1882)
[Finished] [`dc7f1ee2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1867)
[Finished] [`dc7f1ee2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1889)
[Finished] [`dc7f1ee2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1856)
[Finished] [`dc7f1ee2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1881)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14645: ARROW-18290: [C++] Escape all special chars in URI-encoding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14645:
URL: https://github.com/apache/arrow/pull/14645#issuecomment-1315317165
https://issues.apache.org/jira/browse/ARROW-18290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org