You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/05/17 18:25:52 UTC

DO NOT REPLY [Bug 51212] New: QueryStats has synchornisation issues

https://issues.apache.org/bugzilla/show_bug.cgi?id=51212

             Bug #: 51212
           Summary: QueryStats has synchornisation issues
           Product: Tomcat Modules
           Version: unspecified
          Platform: All
            Status: NEW
          Severity: major
          Priority: P2
         Component: jdbc-pool
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: p.mouawad@ubik-ingenierie.com
    Classification: Unclassified


Created attachment 27017
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27017
Patch with Atomic approach

Hello,
I don't know if it is volontary but I think QueryStats fields should be Atomic
because they are accessed by multiple threads at same time.
I made a Load test with heavy load and collected results of SlowQueryReport and
I get Sql queries with 0 as number of executions which is wrong as they have
been executed at least once.

By the way I don't know which approach will perform better:
- synchronize add/failure
- Use Atomic
Maybe you did this for performance reasons.

Regards
Philippe Mouawad
http://www.ubik-ingenierie.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 51212] QueryStats has synchornisation issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51212

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> 2011-05-18 16:35:14 UTC ---
Note that there is still an issue where nbrInvocations is equals to 0.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 51212] QueryStats has synchornisation issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51212

Filip Hanik <fh...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Filip Hanik <fh...@apache.org> 2011-05-18 17:46:16 UTC ---
Fixed in r1124352
no need for atomic, it's a stats collector.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 51212] QueryStats has synchornisation issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51212

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
         OS/Version|                            |All

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 51212] QueryStats has synchornisation issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51212

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27017|0                           |1
        is obsolete|                            |

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> 2011-05-18 16:31:05 UTC ---
Created attachment 27024
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27024
Fix to synchro issue

Previous patch was bugged

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org