You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by CrazyJvm <gi...@git.apache.org> on 2014/06/05 10:41:35 UTC
[GitHub] spark pull request: SPARK-1999: StorageLevel in storage tab and RD...
Github user CrazyJvm commented on a diff in the pull request:
https://github.com/apache/spark/pull/968#discussion_r13429125
--- Diff: core/src/main/scala/org/apache/spark/storage/RDDInfo.scala ---
@@ -33,6 +33,7 @@ class RDDInfo(
var memSize = 0L
var diskSize = 0L
var tachyonSize = 0L
+ var _storageLevel = storageLevel
--- End diff --
i agree with you, so i will change it.
another reason to make storageLevel be a var is that the rdd information also use it. it should be updated, too.
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala#L37-L43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---