You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/19 18:42:16 UTC

[GitHub] jose-torres commented on issue #23836: [SPARK-26915][SQL] DataFrameWriter.save() should write without schema validation

jose-torres commented on issue #23836: [SPARK-26915][SQL] DataFrameWriter.save()  should write without schema validation
URL: https://github.com/apache/spark/pull/23836#issuecomment-465258335
 
 
   I would argue that putting back SaveMode should be on the table, if that's the best way to ensure that queries which work today will work with a v2 file source implementation.
   
   I agree that this PR isn't the right way to go about it. If the v2 ORC implementation doesn't work because of problems in the API, we need to go back to the drawing board and fix the API, not make ad-hoc changes to work around the problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org