You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2022/09/09 11:32:59 UTC
[superset] branch master updated: test: Fix act errors in ResultsPaneOnDashboard test (#21404)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 295de2d098 test: Fix act errors in ResultsPaneOnDashboard test (#21404)
295de2d098 is described below
commit 295de2d0980dd20c5796b856376a614bda9defe2
Author: Lyndsi Kay Williams <55...@users.noreply.github.com>
AuthorDate: Fri Sep 9 06:32:46 2022 -0500
test: Fix act errors in ResultsPaneOnDashboard test (#21404)
---
.../components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx b/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx
index d45149528b..839126bb62 100644
--- a/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx
+++ b/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx
@@ -22,9 +22,10 @@ import userEvent from '@testing-library/user-event';
import {
render,
waitForElementToBeRemoved,
+ waitFor,
} from 'spec/helpers/testing-library';
import { exploreActions } from 'src/explore/actions/exploreActions';
-import { ChartMetadata, ChartPlugin, promiseTimeout } from '@superset-ui/core';
+import { ChartMetadata, ChartPlugin } from '@superset-ui/core';
import { ResultsPaneOnDashboard } from '../components';
import { createResultsPaneOnDashboardProps } from './fixture';
@@ -133,9 +134,9 @@ describe('ResultsPaneOnDashboard', () => {
},
);
- await promiseTimeout(() => {
+ await waitFor(() => {
expect(setForceQuery).toHaveBeenCalledTimes(1);
- }, 10);
+ });
expect(queryByText('2 rows')).toBeVisible();
expect(queryByText('Action')).toBeVisible();
expect(queryByText('Horror')).toBeVisible();