Re: [PR] [SPARK-52017][SQL] Enable multiple self-references and self-references from a Subquery inside rCTEs [spark]

["Pajaraja (via GitHub)" <gi...@apache.org>]

Pajaraja commented on code in PR #50803:
URL: https://github.com/apache/spark/pull/50803#discussion_r2077090978


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/cteOperators.scala:
##########
@@ -106,10 +106,18 @@ case class CTERelationDef(
 
   override def output: Seq[Attribute] = if (resolved) child.output else Nil
 
-  lazy val hasSelfReferenceAsCTERef: Boolean = child.exists{
-    case CTERelationRef(this.id, _, _, _, _, true, _) => true
-    case _ => false
+  def hasReferenceToThisCTE(plan: LogicalPlan): Boolean = {
+    plan.collect {

Review Comment:
   Added collectFirstWithSubqueries.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org