You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GJL <gi...@git.apache.org> on 2017/11/27 12:48:37 UTC

[GitHub] flink pull request #5079: [FLINK-7530][flip6] Migrate SubtaskMetricsHandler ...

GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/5079

    [FLINK-7530][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint

    ## What is the purpose of the change
    
    *FLIP-6 efforts: Migrating HTTP handlers*
    
    ## Brief change log
      - Migrate logic from `org.apache.flink.runtime.rest.handler.legacy.metrics.SubtaskMetricsHandler to` new handler.
      - Add new handler to `DispatcherRestEndpoint`.
    
    ## Verifying this change
    
      - *Added unit tests for all new classes and modified existing classes except for DispatcherRestEndpoint.*
      - *Manually deployed a job locally and verified with `curl` that SubtaskMetrics can be queried in FLIP-6 standalone mode.*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
    
    CC: @tillrohrmann 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-7530

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5079
    
----
commit 24d2ab0a600d476142cfadd453074b01506ba591
Author: gyao <ga...@data-artisans.com>
Date:   2017-11-27T12:30:18Z

    [FLINK-7530][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint
    
    Migrate logic from
    org.apache.flink.runtime.rest.handler.legacy.metrics.SubtaskMetricsHandler to
    new handler. Add new handler to DispatcherRestEndpoint.

commit 2ef55c4d4e94d287f5e8b924e35c79bf53ab957a
Author: gyao <ga...@data-artisans.com>
Date:   2017-11-27T12:32:52Z

    [hotfix][Javadoc] Remove wrong Javadoc from SubtaskMetricsHandler

commit b95b364640b43ba90f62d8c82a6d6c7f93e4ce65
Author: gyao <ga...@data-artisans.com>
Date:   2017-11-27T12:34:02Z

    [hotfix][flip6] Add unit tests JobVertexMetricsHeadersTest

----


---

[GitHub] flink pull request #5079: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler ...

Posted by GJL <gi...@git.apache.org>.
Github user GJL closed the pull request at:

    https://github.com/apache/flink/pull/5079


---

[GitHub] flink issue #5079: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler to new ...

Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on the issue:

    https://github.com/apache/flink/pull/5079
  
    My branch name is wrong. The commit messages are right. Let me know if this is a problem.


---