You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/26 16:09:19 UTC

[GitHub] [calcite-avatica] asolimando commented on pull request #139: [CALCITE-3163] Master calcite 3163 avatica convert value fix

asolimando commented on pull request #139:
URL: https://github.com/apache/calcite-avatica/pull/139#issuecomment-786739740


   > Hey @asolimando, I did a few changes on top your work and rebased in https://github.com/zabetak/calcite-avatica/tree/calcite-3163-reb. Can you have a final look? If everything is good I will push it as is.
   
   Hi Stamatis, thanks a lot for the changes, it looks much better in this way.
   I just realized there is a package for "common" test utilities: `package org.apache.calcite.avatica.test`.
   
   I feel that `AvaticaMatchers.java` would fit better there other than under `org.apache.calcite.avatica.util` where I originally put my test helper class.
   
   In any case LGTM, thanks again!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org