[GitHub] [flink] xintongsong commented on issue #9022: [FLINK-13127] Fix --yarnship classpath

[GitBox <gi...@apache.org>]

xintongsong commented on issue #9022: [FLINK-13127] Fix --yarnship classpath
URL: https://github.com/apache/flink/pull/9022#issuecomment-514024113
 
 
   Hi @dmvk,
   Thanks for opening this PR. I think this is a helpful contribution. A few comments:
   1. I think it would be better if you could find a committer assigning this jira ticket to you before starting the implementation, so other contributors know you are working on this and will not start a redundant work. @tillrohrmann ,could you help assigning the jira ticket?
   2. Agree with @TisonKun, I think this change is not that trivial. It would be better to have a test case to make sure other people won't accidentally break it in the future.
   3. Why do we need to separate and sort archives and resources? I mean, I'm total fine with this because it makes the classpath organized and friendly for people to look into. Just curious whether there is any other reason that makes this necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services