You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/22 16:16:29 UTC

[GitHub] [airflow] xu-xiang opened a new issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

xu-xiang opened a new issue #10479:
URL: https://github.com/apache/airflow/issues/10479


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
   NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
   
   PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
   
   Please complete the next sections or the issue will be closed.
   This questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**:
   ```Airflow Master
   master-python3.8-ci
   docker pull apache/airflow:master-python3.8-ci
   DIGEST:sha256:a4cf33bdbde82b6db6a89b967f4d51ba20101ef815b8bc504cbd9ac1cb659018
   Last updated4 days agobypotiuk
    ```
   
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
   
   **Environment**:
   
   - **Cloud provider or hardware configuration**:
   - **OS** (e.g. from /etc/os-release):
   - **Kernel** (e.g. `uname -a`):
   - **Install tools**:
   - **Others**:
   
   **What happened**:
   API(airflow.api_connexion.endpoints.dag_endpoint.patch_dag) update any DAG info response are:
   400      Property is read-only - '****'
   
   ```
   ➜ ~ curl -v -H "Content-Type: application/json" -X PATCH --data '{ "description": null, "is_paused": true, "schedule_interval": { "__type": "CronExpression", "value": "0 0 * * *" }, "tags": [ { "name": "example" } ]}' http://******/api/v1/dags/example_bash_operator
   
   
   *   Trying 118.*****...
   * TCP_NODELAY set
   * Connected to* (#0)
   > PATCH /api/v1/dags/example_bash_operator HTTP/1.1
   > Host: *
   > User-Agent: curl/7.64.1
   > Accept: */*
   > Content-Type: application/json
   > Content-Length: 325
   >
   * upload completely sent off: 325 out of 325 bytes
   < HTTP/1.1 400 BAD REQUEST
   < Server: gunicorn/19.10.0
   < Date: Sat, 22 Aug 2020 09:29:08 GMT
   < Connection: close
   < Content-Type: application/problem+json
   < Content-Length: 119
   < X-Frame-Options: DENY
   < Vary: Cookie
   < Set-Cookie: session=eyJfcGVybWFuZW50Ijp0cnVlfQ.X0DlZA.1F_VrxgrmOQWHSaA9d_b1czM9SU; Expires=Mon, 21-Sep-2020 09:29:08 GMT; HttpOnly; Path=/
   <
   {
     "detail": "Property is read-only - 'description'",
     "status": 400,
     "title": "Bad Request",
     "type": "about:blank"
   }
   * Closing connection 0
   
   ```
   
   
   <!-- (please include exact error messages if you can) -->
   
   **What you expected to happen**:
   
   <!-- What do you think went wrong? -->
   
   **How to reproduce it**:
   <!---
   
   As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
   
   If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
   
   You can include images using the .md style of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
   
   --->
   
   
   **Anything else we need to know**:
   
   <!--
   
   How often does this problem occur? Once? Every time etc?
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-678669691


   This has been fixed in https://github.com/apache/airflow/pull/9740 . Can you test it with the latest master 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679329725


   Hi @mik-laj , should I work only on the update_mask field and tag this issue to close?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] xu-xiang commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
xu-xiang commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-678863748


   Thank you. I'll test it again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679326244


   Whoops so only is_paused field can be patched .. right! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679325239


   The description is a read-only field according to spec. This field contains the value that is synchronized with the DAG File, so if you want to update this description, you need to edit the DAG File.
   ![Screenshot 2020-08-24 at 21 36 17](https://user-images.githubusercontent.com/12058428/91088187-dea02c80-e651-11ea-9dce-3c44e9fa4b08.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-678683636


   See IMAGES.rst or best you can build it yourself and enter the image using breeze. see BREEZE.rst


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679320973


   @kaxil Yes. I'm happy to help. You can assign it to me


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-678683499


   It should be built nightly on Sunday cjerhub but for latest master it can be pulled from dockerhub 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679319299


   Would you like to create a PR to fix it? @xu-xiang 
   
   cc @ephraimbuddy @OmairK 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-678684163


   Simply checking out the latest master and.running './breeze's should pull&rebuild the image as needed and drop you in the container where you can run tmux, reset the db, start scheduler/ webserver  and run the whole Airflow 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj closed issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #10479:
URL: https://github.com/apache/airflow/issues/10479


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] xu-xiang commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
xu-xiang commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679270150


   I have test it with the latest master. But still respond "Property is read-only - 'description'"
   
   
   ```
   (airflowenv) ➜ github curl -v -X PATCH -H "Content-Type: application/json" --data '{ "description": null}' http://127.0.0.1:8080/api/v1/dags/example_bash_operator
   *   Trying 127.0.0.1...
   * TCP_NODELAY set
   * Connected to 127.0.0.1 (127.0.0.1) port 8080 (#0)
   > PATCH /api/v1/dags/example_bash_operator HTTP/1.1
   > Host: 127.0.0.1:8080
   > User-Agent: curl/7.64.1
   > Accept: */*
   > Content-Type: application/json
   > Content-Length: 22
   >
   * upload completely sent off: 22 out of 22 bytes
   < HTTP/1.1 400 BAD REQUEST
   < Server: gunicorn/19.10.0
   < Date: Mon, 24 Aug 2020 17:37:40 GMT
   < Connection: close
   < Content-Type: application/problem+json
   < Content-Length: 124
   < X-Frame-Options: DENY
   < Vary: Cookie
   < Set-Cookie: session=eyJfcGVybWFuZW50Ijp0cnVlfQ.X0P65A.kt8QcmvtFZ4pXpx9JX1lEjO33rI; Expires=Wed, 23-Sep-2020 17:37:40 GMT; HttpOnly; Path=/
   <
   {
     "detail": "Property is read-only - 'description'",
     "status": 400,
     "title": "Bad Request",
     "type": "about:blank"
   }
   * Closing connection 0
   (airflowenv) ➜ github
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-678685233


   Here is the CI build, that let's you use all the test tool (python  3.6 :  https://github.com/apache/airflow/packages/196408 ) but you find other versions at https://github.com/apache/airflow/packages
   
   All the details on using and runnint the images are in https://github.com/apache/airflow/blob/master/IMAGES.rst
   
   Looking forward to your feedback @xu-xiang
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj edited a comment on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679325239


   The description is a read-only field according to spec. This field contains the value that is synchronized with the DAG File, so if you want to update this description, you need to edit the DAG File.
   ![Screenshot 2020-08-24 at 21 36 17](https://user-images.githubusercontent.com/12058428/91088187-dea02c80-e651-11ea-9dce-3c44e9fa4b08.png)
   https://airflow.readthedocs.io/en/latest/stable-rest-api-ref.html#operation/patch_dag
   However, I can see that there is one mistake here. The update_mask field is missing to maintain future compatibility.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679334909


   @ephraimbuddy Yes. We can close this ticket.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] xu-xiang commented on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
xu-xiang commented on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-678673156


   Is there a docker image whit the latest master?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj edited a comment on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-679325239


   The description is a read-only field according to spec. This field contains the value that is synchronized with the DAG File, so if you want to update this description, you need to edit the DAG File.
   ![Screenshot 2020-08-24 at 21 36 17](https://user-images.githubusercontent.com/12058428/91088187-dea02c80-e651-11ea-9dce-3c44e9fa4b08.png)
   https://airflow.readthedocs.io/en/latest/stable-rest-api-ref.html#operation/patch_dag


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #10479: airflow.api_connexion.endpoints.dag_endpoint.patch_dag -->> Property is read-only - '****'

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #10479:
URL: https://github.com/apache/airflow/issues/10479#issuecomment-678683499


   It should be built nightly on DockerHub but for latest master it can be pulled from dockerhub 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org