You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/22 15:54:44 UTC

[GitHub] [airflow] potiuk commented on pull request #8974: Vault has now VaultHook not only SecretBackend

potiuk commented on pull request #8974:
URL: https://github.com/apache/airflow/pull/8974#issuecomment-632766569


   Hey @ashb @kaxil -> here is the first of the Hooks. This one is implemented for Vault. I extracted the client out of the Backend and added all the missing authentication methods.
   
   I added couple of methods for discovery (to get metadata from v2 version) as well as "cretate_or_update" method. Those methods are not used by the Secret Backend implementation, but they could be in the future.
   
   There is one thing that I found that was (likely) a bit wrong in the previous implementation. 
   I noticed that the 'mount_point" by default was set to "secret", but then different authentication methods have different default mount_points ("gcp" -> "gcp", "ldap" -> "ldap" etc.).
   
   I think I have pretty complete unit test coverage, I will add some system tests still and will test it further, but I wanted to send it to you so that you can take a look and comment early.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org