You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stacic <gi...@git.apache.org> on 2014/10/02 21:59:01 UTC
[GitHub] cordova-mobile-spec pull request: Add new-style tests when using -...
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/110
Add new-style tests when using --plugman option
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-mobile-spec addTestPlugins
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #110
----
commit 8191f3eeed97aa6add997c42618265cb15fb31d4
Author: Staci Cooper <sm...@us.ibm.com>
Date: 2014-10-02T19:53:06Z
Add new-style tests when using --plugman option
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-7713 Add new-style tests when...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-7713 Add new-style tests when...
Posted by cmarcelk <gi...@git.apache.org>.
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18466054
--- Diff: createmobilespec/createmobilespec.js ---
@@ -413,6 +413,20 @@ function installPlugins() {
" install --platform " + platform +
" --project . --plugin " + path.join("..", "cordova-mobile-spec", "dependencies-plugin") +
" --searchpath " + top_dir);
+
+ // Install new-style test plugins
+ console.log("Adding plugin tests using plugman...");
+ shelljs.ls('plugins').forEach(function(plugin) {
--- End diff --
Sounds like the mobilespec-android project is different than wp8:
marcelk-macbook:apache marcelk$ ls -F cordova-android
CONTRIBUTING.md RELEASENOTES.md package.json
LICENSE VERSION spec/
NOTICE bin/ test/
README.md framework/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-7713 Add new-style tests when...
Posted by stacic <gi...@git.apache.org>.
Github user stacic commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18476328
--- Diff: createmobilespec/createmobilespec.js ---
@@ -413,6 +413,20 @@ function installPlugins() {
" install --platform " + platform +
" --project . --plugin " + path.join("..", "cordova-mobile-spec", "dependencies-plugin") +
" --searchpath " + top_dir);
+
+ // Install new-style test plugins
+ console.log("Adding plugin tests using plugman...");
+ shelljs.ls('plugins').forEach(function(plugin) {
--- End diff --
Oh yikes. Didn't realize the project structure was that different -- I've changed it to use the www/plugins dir now, which should be safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: Add new-style tests when using -...
Posted by cmarcelk <gi...@git.apache.org>.
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18420090
--- Diff: createmobilespec/createmobilespec.js ---
@@ -413,6 +413,20 @@ function installPlugins() {
" install --platform " + platform +
" --project . --plugin " + path.join("..", "cordova-mobile-spec", "dependencies-plugin") +
" --searchpath " + top_dir);
+
--- End diff --
These tab chars need to be replaced with spacebar blanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: Add new-style tests when using -...
Posted by cmarcelk <gi...@git.apache.org>.
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18420124
--- Diff: createmobilespec/createmobilespec.js ---
@@ -413,6 +413,20 @@ function installPlugins() {
" install --platform " + platform +
" --project . --plugin " + path.join("..", "cordova-mobile-spec", "dependencies-plugin") +
" --searchpath " + top_dir);
+
+ // Install new-style test plugins
+ console.log("Adding plugin tests using plugman...");
+ shelljs.ls('plugins').forEach(function(plugin) {
--- End diff --
When creating a project with the bin/create command, there is no "plugins" directory. So you won't be able to get the list of plugins from that, as is doable when using the CLI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: Add new-style tests when using -...
Posted by stacic <gi...@git.apache.org>.
Github user stacic commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18438884
--- Diff: createmobilespec/createmobilespec.js ---
@@ -413,6 +413,20 @@ function installPlugins() {
" install --platform " + platform +
" --project . --plugin " + path.join("..", "cordova-mobile-spec", "dependencies-plugin") +
" --searchpath " + top_dir);
+
+ // Install new-style test plugins
+ console.log("Adding plugin tests using plugman...");
+ shelljs.ls('plugins').forEach(function(plugin) {
--- End diff --
There is a top-level Plugins directory (eg mobilespec-wp8/Plugins containing the plugin .cs files), so this does work. On Windows and Mac, at any rate. I did leave it lowercase by accident which I think is an issue on linux.. Let me fix that really quick.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org