You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/01 04:04:22 UTC

[GitHub] [rocketmq] ShadowySpirits opened a new issue, #5626: Optimize DefaultMessageStore#getEarliestMessageTime

ShadowySpirits opened a new issue, #5626:
URL: https://github.com/apache/rocketmq/issues/5626

   When I enable broker metrics I found this error in store.log:
   
   ```
   selectMappedBuffer request pos invalid, request pos: 0, size: 8388608, fileFromoffset: 0
   ```
   
   It is because DefaultMessageStore#getEarliestMessageTime tries to get a buffer of 2 * max message size which defaults to 8M. In the corner case, I have some tiny messages which together are less than 8M, so I get this error.
   
   IMO, 8M is too large in this use case, and We should check offset before getting store time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin closed issue #5626: Optimize DefaultMessageStore#getEarliestMessageTime

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #5626: Optimize DefaultMessageStore#getEarliestMessageTime
URL: https://github.com/apache/rocketmq/issues/5626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] ShadowySpirits commented on issue #5626: Optimize DefaultMessageStore#getEarliestMessageTime

Posted by GitBox <gi...@apache.org>.
ShadowySpirits commented on issue #5626:
URL: https://github.com/apache/rocketmq/issues/5626#issuecomment-1333136862

   @RongtongJin Please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org