You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2023/04/13 15:28:29 UTC
[GitHub] [flink] reswqa opened a new pull request, #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository
reswqa opened a new pull request, #22395:
URL: https://github.com/apache/flink/pull/22395
## What is the purpose of the change
*Each externalized connector has its own yml file to manage the url of uber jar. We should introduce a new shortcode to support this.*
## Brief change log
- *Introduce `py_connector_download_link shortcode` for externalized connectors.*
## Verifying this change
Manually verified.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22395:
URL: https://github.com/apache/flink/pull/22395#issuecomment-1518957498
Thanks @TanYuxin-tyx for the quick review, I have updated this PR according to your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #22395:
URL: https://github.com/apache/flink/pull/22395#issuecomment-1518958068
OK, LGTM after the fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on a diff in pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #22395:
URL: https://github.com/apache/flink/pull/22395#discussion_r1174514057
##########
docs/layouts/shortcodes/py_connector_download_link.html:
##########
@@ -0,0 +1,62 @@
+{{/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/}}{{/*
+Generates an XML snippet for the externalized connector python download table.
+*/}}
+{{ $name := .Get 0 }}
+{{ $connector_version := .Get 1 }}
+{{ $connector := index .Site.Data $name }}
+{{ $flink_version := .Site.Params.VersionTitle }}
+{{ $full_version := printf "%s-%s" $connector_version $flink_version }}
+
+<p>
+{{ if eq $.Site.Language.Lang "en" }}
+In order to use the {{ $connector.name }} in PyFlink jobs, the following
+dependencies are required:
+{{ else if eq $.Site.Language.Lang "zh" }}
+为了在 PyFlink 作业中使用 {{ $connector.name }} ，需要添加下列依赖：
+{{ end }}
+<table>
+ <thead>
+ <th style="text-align: left">Version</th>
+ <th style="text-align: left">PyFlink JAR</th>
+ </thead>
+ <tbody>
+ {{ range $connector.variants }}
+ <tr>
+ <td style="text-align: left">{{- .maven -}}</td>
+ {{ if $.Site.Params.IsStable }}
+ {{ if eq .sql_url nil}}
+ <td style="text-align:left">There is no sql jar available yet.</td>
+ {{ else }}
+ <td style="text-align:left"><a href="{{ replace .sql_url "$full_version" $full_version}}">Download</a></td>
+ {{ end }}
+ {{ else }}
+ <td>Only available for stable releases.</td>
+ {{ end }}
+ </tr>
+ {{ end }}
+ </tbody>
+</table>
+{{ if eq .Site.Language.Lang "en" }}
+See <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/python/dependency_management/#jar-dependencies">Python dependency management</a>
+for more details on how to use JARs in PyFlink.
+{{ else if eq .Site.Language.Lang "zh" }}
+在 PyFlink 中如何添加 JAR 包依赖参见 <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/python/dependency_management/#jar-dependencies">Python 依赖管理</a>。
Review Comment:
Agree with you, `请参考` is more appropriate here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa merged pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #22395:
URL: https://github.com/apache/flink/pull/22395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22395:
URL: https://github.com/apache/flink/pull/22395#issuecomment-1507186045
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f7c0512f39666dbcdb36c1bd187c5ca06bf9842",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8f7c0512f39666dbcdb36c1bd187c5ca06bf9842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f7c0512f39666dbcdb36c1bd187c5ca06bf9842 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on code in PR #22395:
URL: https://github.com/apache/flink/pull/22395#discussion_r1173578262
##########
docs/layouts/shortcodes/py_connector_download_link.html:
##########
@@ -0,0 +1,62 @@
+{{/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/}}{{/*
+Generates an XML snippet for the externalized connector python download table.
+*/}}
+{{ $name := .Get 0 }}
+{{ $connector_version := .Get 1 }}
+{{ $connector := index .Site.Data $name }}
+{{ $flink_version := .Site.Params.VersionTitle }}
+{{ $full_version := printf "%s-%s" $connector_version $flink_version }}
+
+<p>
+{{ if eq $.Site.Language.Lang "en" }}
+In order to use the {{ $connector.name }} in PyFlink jobs, the following
+dependencies are required:
+{{ else if eq $.Site.Language.Lang "zh" }}
+为了在 PyFlink 作业中使用 {{ $connector.name }} ，需要添加下列依赖：
+{{ end }}
+<table>
+ <thead>
+ <th style="text-align: left">Version</th>
+ <th style="text-align: left">PyFlink JAR</th>
+ </thead>
+ <tbody>
+ {{ range $connector.variants }}
+ <tr>
+ <td style="text-align: left">{{- .maven -}}</td>
+ {{ if $.Site.Params.IsStable }}
+ {{ if eq .sql_url nil}}
+ <td style="text-align:left">There is no sql jar available yet.</td>
+ {{ else }}
+ <td style="text-align:left"><a href="{{ replace .sql_url "$full_version" $full_version}}">Download</a></td>
+ {{ end }}
+ {{ else }}
+ <td>Only available for stable releases.</td>
+ {{ end }}
+ </tr>
+ {{ end }}
+ </tbody>
+</table>
+{{ if eq .Site.Language.Lang "en" }}
+See <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/python/dependency_management/#jar-dependencies">Python dependency management</a>
+for more details on how to use JARs in PyFlink.
+{{ else if eq .Site.Language.Lang "zh" }}
+在 PyFlink 中如何添加 JAR 包依赖参见 <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/python/dependency_management/#jar-dependencies">Python 依赖管理</a>。
Review Comment:
"参见" is a little strange, maybe "请参考". But I see that it is also like this in `py_download_link.html`. So fixing or not fixing is both fine, no strong opinions.
BTW, if fixing this, then the one in the `py_download_link.html` should also be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org