You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by su...@apache.org on 2020/06/28 03:11:52 UTC

[incubator-echarts] branch next updated: fix: the first param of stopAnimation became "scope".

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/next by this push:
     new 3376031  fix: the first param of stopAnimation became "scope".
3376031 is described below

commit 3376031f556b14a188dfc7e41d43304d62948149
Author: 100pah <su...@gmail.com>
AuthorDate: Sun Jun 28 11:11:09 2020 +0800

    fix: the first param of stopAnimation became "scope".
---
 src/chart/helper/Symbol.ts                   | 2 +-
 src/chart/line/LineView.ts                   | 2 +-
 src/chart/pie/PieView.ts                     | 8 ++++----
 src/component/timeline/SliderTimelineView.ts | 2 +-
 src/echarts.ts                               | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/chart/helper/Symbol.ts b/src/chart/helper/Symbol.ts
index baab515..bdc7e99 100644
--- a/src/chart/helper/Symbol.ts
+++ b/src/chart/helper/Symbol.ts
@@ -95,7 +95,7 @@ class Symbol extends graphic.Group {
      * @param {boolean} toLastFrame
      */
     stopSymbolAnimation(toLastFrame: boolean) {
-        this.childAt(0).stopAnimation(toLastFrame);
+        this.childAt(0).stopAnimation(null, toLastFrame);
     }
 
     /**
diff --git a/src/chart/line/LineView.ts b/src/chart/line/LineView.ts
index 22dc22a..e0342f3 100644
--- a/src/chart/line/LineView.ts
+++ b/src/chart/line/LineView.ts
@@ -501,7 +501,7 @@ class LineView extends ChartView {
             // Stop symbol animation and sync with line points
             // FIXME performance?
             data.eachItemGraphicEl(function (el) {
-                el.stopAnimation(true);
+                el.stopAnimation(null, true);
             });
 
             // In the case data zoom triggerred refreshing frequently
diff --git a/src/chart/pie/PieView.ts b/src/chart/pie/PieView.ts
index 4477ab1..2c1d615 100644
--- a/src/chart/pie/PieView.ts
+++ b/src/chart/pie/PieView.ts
@@ -183,7 +183,7 @@ class PiePiece extends graphic.Group {
                     if (toState === 'emphasis') {
                         // Sector may has animation of updating data. Force to move to the last frame
                         // Or it may stopped on the wrong shape
-                        sector.stopAnimation(true);
+                        sector.stopAnimation(null, true);
                         sector.animateTo({
                             shape: {
                                 r: layout.r + seriesModel.get('hoverOffset')
@@ -191,7 +191,7 @@ class PiePiece extends graphic.Group {
                         }, { duration: 300, easing: 'elasticOut' });
                     }
                     else {
-                        sector.stopAnimation(true);
+                        sector.stopAnimation(null, true);
                         sector.animateTo({
                             shape: {
                                 r: layout.r
@@ -361,7 +361,7 @@ class PieView extends ChartView {
                 // Default expansion animation
                 if (isFirstRender && animationType !== 'scale') {
                     piePiece.eachChild(function (child) {
-                        child.stopAnimation(true);
+                        child.stopAnimation(null, true);
                     });
                 }
 
@@ -378,7 +378,7 @@ class PieView extends ChartView {
 
                 if (!isFirstRender && animationTypeUpdate !== 'transition') {
                     piePiece.eachChild(function (child) {
-                        child.stopAnimation(true);
+                        child.stopAnimation(null, true);
                     });
                 }
 
diff --git a/src/component/timeline/SliderTimelineView.ts b/src/component/timeline/SliderTimelineView.ts
index e8dc40d..5bced31 100644
--- a/src/component/timeline/SliderTimelineView.ts
+++ b/src/component/timeline/SliderTimelineView.ts
@@ -795,7 +795,7 @@ function pointerMoveTo(
         pointer.y = 0;
     }
     else {
-        pointer.stopAnimation(true);
+        pointer.stopAnimation(null, true);
         pointer.animateTo({
             x: toCoord,
             y: 0
diff --git a/src/echarts.ts b/src/echarts.ts
index eeca2de..765ee6a 100644
--- a/src/echarts.ts
+++ b/src/echarts.ts
@@ -553,7 +553,7 @@ class ECharts extends Eventful {
         const list = zr.storage.getDisplayList();
         // Stop animations
         zrUtil.each(list, function (el: Element) {
-            el.stopAnimation(true);
+            el.stopAnimation(null, true);
         });
 
         return (zr.painter as SVGPainter).toDataURL();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org