[jira] Commented: (DIRMINA-40) Filter API needs callback for enabled notification

["Vinod Panicker (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/DIRMINA-40?page=comments#action_12313962 ] 

Vinod Panicker commented on DIRMINA-40:
---------------------------------------

init() and destroy() without any input parameters are not useful esp for filters such as the SSLFilter.

Taking the example of SSLFilter, an instance of SSLHandler should be logically created in init() if the filter is being applied on a Session that is already active.  But in this case, since no Session object is being passed, the filter cant do anything.  Also, what should be passed in init() when the filter is being applied on an Acceptor?

> Filter API needs callback for enabled notification
> --------------------------------------------------
>
>          Key: DIRMINA-40
>          URL: http://issues.apache.org/jira/browse/DIRMINA-40
>      Project: Directory MINA
>         Type: Improvement
>     Versions: 0.7, 0.7.1
>  Environment: All
>     Reporter: Vinod Panicker
>     Assignee: Trustin Lee
>     Priority: Blocker
>      Fix For: 0.9

>
> The Filter api currently assumes that it would be applied only on unopened sessions.  Eg - the SSL filter currently starts its work on the sessionOpened() callback.  This is an incorrect assumption since the SSL filter could be applied on an existing plain TCP connection as well.
> It would be great if there were new callbacks defined  - something like filterEnabled() and filterDisabled()
> This would allow us to use the filters on existing sessions as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira