You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by sr...@apache.org on 2010/01/30 16:15:37 UTC

svn commit: r904786 - in /lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop: item/RecommenderJob.java pseudo/RecommenderJob.java slopeone/SlopeOneAverageDiffsJob.java

Author: srowen
Date: Sat Jan 30 15:15:36 2010
New Revision: 904786

URL: http://svn.apache.org/viewvc?rev=904786&view=rev
Log:
Typo, error handling fix

Modified:
    lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/item/RecommenderJob.java
    lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/pseudo/RecommenderJob.java
    lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/slopeone/SlopeOneAverageDiffsJob.java

Modified: lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/item/RecommenderJob.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/item/RecommenderJob.java?rev=904786&r1=904785&r2=904786&view=diff
==============================================================================
--- lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/item/RecommenderJob.java (original)
+++ lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/item/RecommenderJob.java Sat Jan 30 15:15:36 2010
@@ -63,9 +63,12 @@
   public int run(String[] args) throws IOException {
 
     Option numReccomendationsOpt = buildOption("numRecommendations", "n", "Number of recommendations per user", "10");
-    Option usersFileOpt = buildOption("usersFile", "n", "Number of recommendations per user", null);
+    Option usersFileOpt = buildOption("usersFile", "u", "File of users to recommend for", null);
 
     Map<String,String> parsedArgs = parseArguments(args, numReccomendationsOpt, usersFileOpt);
+    if (parsedArgs == null) {
+      return -1;
+    }
 
     String inputPath = parsedArgs.get("--input");
     String tempDirPath = parsedArgs.get("--tempDir");

Modified: lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/pseudo/RecommenderJob.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/pseudo/RecommenderJob.java?rev=904786&r1=904785&r2=904786&view=diff
==============================================================================
--- lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/pseudo/RecommenderJob.java (original)
+++ lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/pseudo/RecommenderJob.java Sat Jan 30 15:15:36 2010
@@ -101,6 +101,9 @@
 
     Map<String,String> parsedArgs =
         parseArguments(args, recommendClassOpt, numReccomendationsOpt, usersFileOpt);
+    if (parsedArgs == null) {
+      return -1;
+    }
     String inputFile = parsedArgs.get("--input");
     String outputPath = parsedArgs.get("--output");
     String jarFile = parsedArgs.get("--jarFile");

Modified: lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/slopeone/SlopeOneAverageDiffsJob.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/slopeone/SlopeOneAverageDiffsJob.java?rev=904786&r1=904785&r2=904786&view=diff
==============================================================================
--- lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/slopeone/SlopeOneAverageDiffsJob.java (original)
+++ lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/slopeone/SlopeOneAverageDiffsJob.java Sat Jan 30 15:15:36 2010
@@ -43,6 +43,9 @@
   public int run(String[] args) throws IOException {
 
     Map<String,String> parsedArgs = parseArguments(args);
+    if (parsedArgs == null) {
+      return -1;
+    }
 
     String prefsFile = parsedArgs.get("--input");
     String outputPath = parsedArgs.get("--output");