You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/19 04:19:35 UTC

[GitHub] [lucene] mocobeta opened a new pull request #693: LUCENE-10400: revise binary dictionaries' constructor in nori

mocobeta opened a new pull request #693:
URL: https://github.com/apache/lucene/pull/693


   This applies the same changes as #643 to Nori.
   
   - Add new constructors that take Path object to load external resources.
   - Add tests for the new constructors.
   - Deprecate the old constructors to switch the resource location (classpath/file path).
   - Always use Class.getResourceAsStream() to load class resources.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mocobeta merged pull request #693: LUCENE-10400: revise binary dictionaries' constructor in nori

Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #693:
URL: https://github.com/apache/lucene/pull/693


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mocobeta commented on pull request #693: LUCENE-10400: revise binary dictionaries' constructor in nori

Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #693:
URL: https://github.com/apache/lucene/pull/693#issuecomment-1046177607


   > We will also have a second PR to remove the deprecated APIs in main branch?
   
   Yes, I will.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org