[jira] [Comment Edited] (HBASE-21881) Use Forbidden API Checker to prevent future usages of forbidden api's

["Nihal Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766120#comment-16766120 ] 

Nihal Jain edited comment on HBASE-21881 at 2/12/19 3:06 PM:
-------------------------------------------------------------

{quote} Maybe add it to {{pluginManagement}} and add a non-voting test plugin to our yetus personality. 
{quote}
[~busbey] The plugin results in a compilation error if any forbidden api is used. Do we want to just disable compilation failure (not sure whether the plugin allows to do this) and add a yetus plugin which gives -1, in case a forbidden api is used?


was (Author: nihaljain.cs):
{quote} Maybe add it to {{pluginManagement}} and add a non-voting test plugin to our yetus personality. 
{quote}
The plugin results in a compilation error if any forbidden api is used. Do we want to just disable compilation failure (not sure whether the plugin allows to do this) and add a yetus plugin which gives -1, in case a forbidden api is used?

> Use Forbidden API Checker to prevent future usages of forbidden api's
> ---------------------------------------------------------------------
>
>                 Key: HBASE-21881
>                 URL: https://issues.apache.org/jira/browse/HBASE-21881
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Nihal Jain
>            Priority: Major
>
> [Policeman's Forbidden API Checker|https://github.com/policeman-tools/forbidden-apis] provides an elegant way to fail build if any "forbidden api" is used in the code base.
> Here we will add the plugin to our pom.xml.
> We will discuss which all api's to put in forbidden list. Or whether to use the one's bundled with the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)