You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/11 15:03:16 UTC
[GitHub] [skywalking-cli] fgksgf opened a new pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
fgksgf opened a new pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80
close apache/skywalking#5985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-io edited a comment on pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80#issuecomment-743245202
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=h1) Report
> Merging [#80](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=desc) (3122519) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/98913520f0c3664a57e58d0618c57844fd3b2f55?el=desc) (9891352) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 44.89% 44.89%
=======================================
Files 9 9
Lines 147 147
=======================================
Hits 66 66
Misses 73 73
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=footer). Last update [9891352...3122519](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-io edited a comment on pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80#issuecomment-743245202
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=h1) Report
> Merging [#80](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=desc) (3160af0) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/98913520f0c3664a57e58d0618c57844fd3b2f55?el=desc) (9891352) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 44.89% 44.89%
=======================================
Files 9 9
Lines 147 147
=======================================
Hits 66 66
Misses 73 73
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=footer). Last update [9891352...3160af0](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-io edited a comment on pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80#issuecomment-743245202
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=h1) Report
> Merging [#80](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=desc) (769f5ce) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/98913520f0c3664a57e58d0618c57844fd3b2f55?el=desc) (9891352) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 44.89% 44.89%
=======================================
Files 9 9
Lines 147 147
=======================================
Hits 66 66
Misses 73 73
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=footer). Last update [9891352...769f5ce](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-io commented on pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80#issuecomment-743245202
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=h1) Report
> Merging [#80](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=desc) (7bc548f) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/2b7fae8a189e517b43e374fb9ddbf3a564969037?el=desc) (2b7fae8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 44.89% 44.89%
=======================================
Files 9 9
Lines 147 147
=======================================
Hits 66 66
Misses 73 73
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=footer). Last update [2b7fae8...7bc548f](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-io edited a comment on pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80#issuecomment-743245202
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=h1) Report
> Merging [#80](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=desc) (d078c8c) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/98913520f0c3664a57e58d0618c57844fd3b2f55?el=desc) (9891352) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 44.89% 44.89%
=======================================
Files 9 9
Lines 147 147
=======================================
Hits 66 66
Misses 73 73
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=footer). Last update [9891352...d078c8c](https://codecov.io/gh/apache/skywalking-cli/pull/80?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 merged pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80#issuecomment-743966774
I think this PR missed one important step, verification. The test passed doesn't only mean `runnable` w/o exception, also should check the expected data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] fgksgf commented on pull request #80: Set up a simple test with GitHub Actions to verify the minimal functionalities
Posted by GitBox <gi...@apache.org>.
fgksgf commented on pull request #80:
URL: https://github.com/apache/skywalking-cli/pull/80#issuecomment-743978242
> I think this PR missed one important step, verification. The test passed doesn't only mean `runnable` w/o exception, also should check the expected data.
Yes, as the [issue](https://github.com/apache/skywalking/issues/5985) inferred, this is just a simple test. I think the verification would be part of the next generation E2E test framework.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org