You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/29 16:50:34 UTC
[GitHub] [airflow] andrew-candela opened a new pull request #17896: Adds Github Oauth example with team based authorization
andrew-candela opened a new pull request #17896:
URL: https://github.com/apache/airflow/pull/17896
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Since Airflow 2 users must modify the default the security manager to use Github team membership for Authorization. This is a tall order for folks who may not be familiar with Airflow and FAB (like me).
This PR adds a section in the webserver documentation with an example of how to use github teams for authorization, along with GH OAuth for authentication. It demonstrates how to overwrite the default security manager and how to configure `webserver_config.py` so that FAB maps roles returned from the new custom security manager to roles that it expects.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andrew-candela commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
andrew-candela commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-908543482
Ah yes, I hadn't completed the pre-commit setup instructions. Should be ok this time. Thanks for the review guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-909440620
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andrew-candela commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
andrew-candela commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-908543482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-908305179
Yeah. Please install `pre-commit` - it will fix all those errors for you automatically. Other than that it looks great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-909440538
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andrew-candela commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
andrew-candela commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-908581010
hrmm.. Now I've made it to a new error that looks related to the constraints files..
```
ERROR: Cannot install apache-airflow-providers-celery==2.0.0.dev0 because these package versions have conflicting dependencies.
```
This seems unrelated to my changes, unless I'm missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17896:
URL: https://github.com/apache/airflow/pull/17896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-909440728
good job @andrew-candela !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andrew-candela commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
andrew-candela commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-909510360
Woo! Thanks for all the help @potiuk !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-909440538
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andrew-candela commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
andrew-candela commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-909310907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-907825833
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-908183792
Please fix the static check failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-909440728
good job @andrew-candela !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-908305179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17896:
URL: https://github.com/apache/airflow/pull/17896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-909440620
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17896: Adds Github Oauth example with team based authorization
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17896:
URL: https://github.com/apache/airflow/pull/17896#issuecomment-908581047
Can you also please rebase to latest main ? We've merged Celery 5 changes which make older branches incompatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org