You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2017/08/04 18:26:14 UTC

[kudu-CR] [build] Fix Python build failures on RHEL 6

Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7589

to review the following change.

Change subject: [build] Fix Python build failures on RHEL 6
......................................................................

[build] Fix Python build failures on RHEL 6

Internal build machines running RHEL 6 started failing recently on something
that looks a lot like: https://github.com/pypa/pip/issues/3045

But we already have the fix in. This patch works around the problem by upgrading
setuptools separately which somehow works.

Change-Id: I05ddecc4f903607f1131015277c1f36f2d766acb
---
M build-support/jenkins/build-and-test.sh
M python/requirements.txt
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/7589/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05ddecc4f903607f1131015277c1f36f2d766acb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [build] Fix Python build failures on RHEL 6

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: [build] Fix Python build failures on RHEL 6
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05ddecc4f903607f1131015277c1f36f2d766acb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [build] Fix Python build failures on RHEL 6

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: [build] Fix Python build failures on RHEL 6
......................................................................


Patch Set 1: Verified+1

Overriding jenkins, I doubt a Python build change had an impact on Java tests.

-- 
To view, visit http://gerrit.cloudera.org:8080/7589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05ddecc4f903607f1131015277c1f36f2d766acb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [build] Fix Python build failures on RHEL 6

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: [build] Fix Python build failures on RHEL 6
......................................................................


Patch Set 1:

I'll keep looking for a "non-workaround" version.

-- 
To view, visit http://gerrit.cloudera.org:8080/7589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05ddecc4f903607f1131015277c1f36f2d766acb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [build] Fix Python build failures on RHEL 6

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: [build] Fix Python build failures on RHEL 6
......................................................................


[build] Fix Python build failures on RHEL 6

Internal build machines running RHEL 6 started failing recently on something
that looks a lot like: https://github.com/pypa/pip/issues/3045

But we already have the fix in. This patch works around the problem by upgrading
setuptools separately which somehow works.

Change-Id: I05ddecc4f903607f1131015277c1f36f2d766acb
Reviewed-on: http://gerrit.cloudera.org:8080/7589
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Jean-Daniel Cryans <jd...@apache.org>
---
M build-support/jenkins/build-and-test.sh
M python/requirements.txt
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Jean-Daniel Cryans: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05ddecc4f903607f1131015277c1f36f2d766acb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>