You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/06 15:36:34 UTC
[GitHub] [airflow] mik-laj opened a new pull request #14643: Create a new documentation package for Helm Chart
mik-laj opened a new pull request #14643:
URL: https://github.com/apache/airflow/pull/14643
Part of: https://github.com/apache/airflow/issues/14303
I have extracted the documentation from README.md to a separate package to make it easier for us to publish it on the site. This will also facilitate our documentation development as we have several files and not just one file. Previously, contributors didn't always add documentation to avoid cluttering the README.md file, which was already getting very long.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14643: Create a new documentation package for Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14643:
URL: https://github.com/apache/airflow/pull/14643#discussion_r588912167
##########
File path: docs/helm-chart/keda.rst
##########
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Autoscaling with KEDA
+---------------------
+
+*This feature is still experimental.*
+
+KEDA stands for Kubernetes Event Driven Autoscaling.
+`KEDA <https://github.com/kedacore/keda>`__ is a custom controller that
+allows users to create custom bindings to the Kubernetes `Horizontal Pod
+Autoscaler <https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/>`__.
+We have built a scaler that allows users to create scalers based on
Review comment:
we should describe the scaller for MySQL as well, but I would prefer to do it as a separate ticket. for now, I am changing the structure, but without changing the content.
Helm Chart supports PostgreSQL and MySQL. in cluster postgres is only intended for testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14643: Create a new documentation package for Helm Chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14643:
URL: https://github.com/apache/airflow/pull/14643#issuecomment-791989530
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14643: Create a new documentation package for Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14643:
URL: https://github.com/apache/airflow/pull/14643#discussion_r588916352
##########
File path: docs/helm-chart/keda.rst
##########
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Autoscaling with KEDA
+---------------------
+
+*This feature is still experimental.*
+
+KEDA stands for Kubernetes Event Driven Autoscaling.
+`KEDA <https://github.com/kedacore/keda>`__ is a custom controller that
+allows users to create custom bindings to the Kubernetes `Horizontal Pod
+Autoscaler <https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/>`__.
+We have built a scalers that allows users to create scalers based on
Review comment:
```suggestion
We have built scalers that allows users to create scalers based on
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #14643: Create a new documentation package for Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #14643:
URL: https://github.com/apache/airflow/pull/14643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #14643: Create a new documentation package for Helm Chart
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #14643:
URL: https://github.com/apache/airflow/pull/14643#discussion_r588904246
##########
File path: docs/helm-chart/keda.rst
##########
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Autoscaling with KEDA
+---------------------
+
+*This feature is still experimental.*
+
+KEDA stands for Kubernetes Event Driven Autoscaling.
+`KEDA <https://github.com/kedacore/keda>`__ is a custom controller that
+allows users to create custom bindings to the Kubernetes `Horizontal Pod
+Autoscaler <https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/>`__.
+We have built a scaler that allows users to create scalers based on
Review comment:
```suggestion
We have built a scalers that allows users to create scalers based on
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14643: Create a new documentation package for Helm Chart
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14643:
URL: https://github.com/apache/airflow/pull/14643#discussion_r588915915
##########
File path: docs/helm-chart/keda.rst
##########
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Autoscaling with KEDA
+---------------------
+
+*This feature is still experimental.*
+
+KEDA stands for Kubernetes Event Driven Autoscaling.
+`KEDA <https://github.com/kedacore/keda>`__ is a custom controller that
+allows users to create custom bindings to the Kubernetes `Horizontal Pod
+Autoscaler <https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/>`__.
+We have built a scaler that allows users to create scalers based on
Review comment:
`a scaler` or `scallers` (but not `a scallers`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #14643: Create a new documentation package for Helm Chart
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #14643:
URL: https://github.com/apache/airflow/pull/14643#discussion_r588904572
##########
File path: docs/helm-chart/keda.rst
##########
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Autoscaling with KEDA
+---------------------
+
+*This feature is still experimental.*
+
+KEDA stands for Kubernetes Event Driven Autoscaling.
+`KEDA <https://github.com/kedacore/keda>`__ is a custom controller that
+allows users to create custom bindings to the Kubernetes `Horizontal Pod
+Autoscaler <https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/>`__.
+We have built a scaler that allows users to create scalers based on
Review comment:
There are 3 scalers that can be used with Airflow and all build by Daniel or me. But I assume we should mention only PostgreSQL later on as Postgres is part fo chart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org