You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/25 13:53:53 UTC
[GitHub] [incubator-doris] kangkaisen opened a new pull request #2991:
Output null for hll and bitmap column when select *
kangkaisen opened a new pull request #2991: Output null for hll and bitmap column when select *
URL: https://github.com/apache/incubator-doris/pull/2991
For https://github.com/apache/incubator-doris/issues/2976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #2991: Output null for
hll and bitmap column when select *
Posted by GitBox <gi...@apache.org>.
imay merged pull request #2991: Output null for hll and bitmap column when select *
URL: https://github.com/apache/incubator-doris/pull/2991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2991:
Output null for hll and bitmap column when select *
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2991: Output null for hll and bitmap column when select *
URL: https://github.com/apache/incubator-doris/pull/2991#discussion_r384316760
##########
File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java
##########
@@ -786,15 +785,14 @@ private void expandStar(Analyzer analyzer, TableName tblName) throws AnalysisExc
* Expand "*" for a particular tuple descriptor by appending
* refs for each column to selectListExprs.
*/
- private void expandStar(TableName tblName, TupleDescriptor desc) throws AnalysisException {
+ private void expandStar(TableName tblName, TupleDescriptor desc) {
for (Column col : desc.getTable().getBaseSchema()) {
- if (col.getDataType() == PrimitiveType.HLL && !fromInsert) {
- throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
- }
- if (col.getAggregationType() == AggregateType.BITMAP_UNION && !fromInsert) {
- throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
+ PrimitiveType type = col.getDataType();
Review comment:
> 1. there is a performance issue, we still need to scan the HLL or Bitmap column
I think performance may not be very important in this case
> 2. we need to support return binary content for HLL or Bitmap, so we shouldn't send null directly in ResultSink, we must pass a config from FE to BE.
Maybe we can support this feature later, and wait until the situation is really needed? Or the user can get the encoded readable content through the hex or base64 function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#2991: Output null for hll and bitmap column when select *
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #2991: Output null for hll and bitmap column when select *
URL: https://github.com/apache/incubator-doris/pull/2991#discussion_r384300912
##########
File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java
##########
@@ -786,15 +785,14 @@ private void expandStar(Analyzer analyzer, TableName tblName) throws AnalysisExc
* Expand "*" for a particular tuple descriptor by appending
* refs for each column to selectListExprs.
*/
- private void expandStar(TableName tblName, TupleDescriptor desc) throws AnalysisException {
+ private void expandStar(TableName tblName, TupleDescriptor desc) {
for (Column col : desc.getTable().getBaseSchema()) {
- if (col.getDataType() == PrimitiveType.HLL && !fromInsert) {
- throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
- }
- if (col.getAggregationType() == AggregateType.BITMAP_UNION && !fromInsert) {
- throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
+ PrimitiveType type = col.getDataType();
Review comment:
If we handle in backend:
1. there is a performance issue, we still need to scan the HLL or Bitmap column
2. we need to support return binary content for HLL or Bitmap, so we shouldn't send null directly in ResultSink, we must pass a config from FE to BE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2991:
Output null for hll and bitmap column when select *
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2991: Output null for hll and bitmap column when select *
URL: https://github.com/apache/incubator-doris/pull/2991#discussion_r384252598
##########
File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java
##########
@@ -786,15 +785,14 @@ private void expandStar(Analyzer analyzer, TableName tblName) throws AnalysisExc
* Expand "*" for a particular tuple descriptor by appending
* refs for each column to selectListExprs.
*/
- private void expandStar(TableName tblName, TupleDescriptor desc) throws AnalysisException {
+ private void expandStar(TableName tblName, TupleDescriptor desc) {
for (Column col : desc.getTable().getBaseSchema()) {
- if (col.getDataType() == PrimitiveType.HLL && !fromInsert) {
- throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
- }
- if (col.getAggregationType() == AggregateType.BITMAP_UNION && !fromInsert) {
- throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
+ PrimitiveType type = col.getDataType();
Review comment:
I don't think this change is very suitable.
1. I think the behavior of `select *` and `select a specific column` should be consistent.
2. The current modification method may have problems when inserting into select *, or when sub-queries, such as select hll_union (hll_col) from (select *);
I think we can do it in backend. When encountering HLL type or Bitmap type, ResultSink can send null directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org