[jira] [Commented] (FLINK-2500) Some reviews to improve code quality

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662740#comment-14662740 ] 

ASF GitHub Bot commented on FLINK-2500:
---------------------------------------

GitHub user HuangWHWHW opened a pull request:

    https://github.com/apache/flink/pull/1001

    [FLINK-2500][Streaming]remove a unwanted "if" branch

    This "if" is pointless since the "for" will do the same check.
    And add a new temporary var(int size)  so that “dataStream.unionedStreams.size()” will just be called once.
    Instead "dataStream.unionedStreams.size()" will be called every time when "i++" and it do harm to the performance.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HuangWHWHW/flink FLINK-2500

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1001.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1001
    
----
commit ed3bc7e07f0a40f14b06ca11874799d921772101
Author: HuangWHWHW <40...@qq.com>
Date:   2015-08-08T01:31:08Z

    [FLINK-2500][Streaming]remove a unwanted "if" branch

----


> Some reviews to improve code quality
> ------------------------------------
>
>                 Key: FLINK-2500
>                 URL: https://issues.apache.org/jira/browse/FLINK-2500
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 0.10
>            Reporter: Huang Wei
>            Priority: Minor
>             Fix For: 0.10
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> I reviewed the Streaming module and there are some suggestions to improve the code quality(.i.e reduce the complexity of the loop, fix memory leak...).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)