You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2010/08/12 15:05:17 UTC

[jira] Commented: (WICKET-2979) Handle Error instead of RuntimeException in RequestCycle.step()

    [ https://issues.apache.org/jira/browse/WICKET-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897734#action_12897734 ] 

Martin Grigorov commented on WICKET-2979:
-----------------------------------------

Catching *Error is never a good thing.
Better use "throw Invalid(State|Argument)Exception" instead of "assert something".
Disabling assertions in production is also a better idea.

> Handle Error instead of RuntimeException in RequestCycle.step()
> ---------------------------------------------------------------
>
>                 Key: WICKET-2979
>                 URL: https://issues.apache.org/jira/browse/WICKET-2979
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Florian Wunderlich
>
> RequestCycle.java:1346 catches only RuntimeException, thus AssertionError and similar are not caught. In case of an AJAX request, the container will respond with an error page which the user will never see.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.