[GitHub] [arrow] mapleFU commented on a diff in pull request #34355: GH-34351: [C++][Parquet] Statistic: tiny optimization

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #34355:
URL: https://github.com/apache/arrow/pull/34355#discussion_r1118221866


##########
cpp/src/parquet/statistics.cc:
##########
@@ -620,7 +626,11 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
  private:
   const ColumnDescriptor* descr_;
   bool has_min_max_ = false;
+  // Currently, has_null_count_ is always true, and would

Review Comment:
   Yes, default value is false, but ctor will ensure that it is true. I can update it to `true`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org