You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/23 06:32:59 UTC

[GitHub] [echarts] pissang opened a new pull request #14767: fix(geo): fix tooltip don't show on geo component.

pissang opened a new pull request #14767:
URL: https://github.com/apache/echarts/pull/14767


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   1. Default to show tooltip on geo component. 
   > This is because in 5.1.0 geo component enabled tooltip for supporting SVG but set show to false by default. Which will cause all series using this geo component don't show tooltip by default.
   2. Fix the wrong usage of `setState` in the map. Which may have unexpected error logs(only log, not throw an exception).
   3. Update package-lock.json to avoid CI failure.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang closed pull request #14767: fix(geo): fix tooltip don't show on geo component.

Posted by GitBox <gi...@apache.org>.
pissang closed pull request #14767:
URL: https://github.com/apache/echarts/pull/14767


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14767: fix(geo): fix tooltip don't show on geo component.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14767:
URL: https://github.com/apache/echarts/pull/14767#issuecomment-825424461


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org