You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/26 06:26:24 UTC
[GitHub] [fineract] maektwain opened a new pull request #1114: FINERACT-1057
maektwain opened a new pull request #1114:
URL: https://github.com/apache/fineract/pull/1114
## Description
This is a fix for various ISSUE
1. Spring Security Update
2. Auto configurer for oauth
3. Running oauth including jax-api
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] maektwain commented on pull request #1114: FINERACT-1057 - Running -Psecurity=oauth leads to memory leak issue
Posted by GitBox <gi...@apache.org>.
maektwain commented on pull request #1114:
URL: https://github.com/apache/fineract/pull/1114#issuecomment-660250486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] maektwain closed pull request #1114: FINERACT-1057 - Running -Psecurity=oauth leads to memory leak issue
Posted by GitBox <gi...@apache.org>.
maektwain closed pull request #1114:
URL: https://github.com/apache/fineract/pull/1114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1114: FINERACT-1057 - Running -Psecurity=oauth leads to memory leak issue
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1114:
URL: https://github.com/apache/fineract/pull/1114#issuecomment-680418215
It appears this PR overlaps with #1258 and #1259? please do not open several parallel competing PRs for the same JIRA, but work on a single one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1114: FINERACT-1057 - Running -Psecurity=oauth leads to memory leak issue
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1114:
URL: https://github.com/apache/fineract/pull/1114#issuecomment-653843895
`/home/travis/build/apache/fineract/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/api/UserDetailsApiResource.java:62: error: cannot find symbol
@Api(tags = { "Fetch authenticated user details" })
^
symbol: class Api
/home/travis/build/apache/fineract/fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/api/UserDetailsApiResource.java:63: error: cannot find symbol
@SwaggerDefinition(tags = { @Tag(name = "Fetch authenticated user details", description = "") })
^
symbol: class SwaggerDefinition
2 errors
FAILURE: Build failed with an exception.`
@maektwain Build failing cause of these. Mind checking them out?
There are also some merge conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] maektwain commented on pull request #1114: FINERACT-1057 - Running -Psecurity=oauth leads to memory leak issue
Posted by GitBox <gi...@apache.org>.
maektwain commented on pull request #1114:
URL: https://github.com/apache/fineract/pull/1114#issuecomment-653844308
Yes I fixed this let me push this also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] edcable commented on pull request #1114: FINERACT-1057 - Running -Psecurity=oauth leads to memory leak issue
Posted by GitBox <gi...@apache.org>.
edcable commented on pull request #1114:
URL: https://github.com/apache/fineract/pull/1114#issuecomment-673627652
@maektwain have you been able to split this up into multiple PRs? Can you please create the tickets and open up new PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on a change in pull request #1114: FINERACT-1057 - Running -Psecurity=oauth leads to memory leak issue
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #1114:
URL: https://github.com/apache/fineract/pull/1114#discussion_r449835259
##########
File path: fineract-provider/dependencies.gradle
##########
@@ -30,7 +30,8 @@ dependencies {
//
implementation(
//'ch.vorburger.mariaDB4j:mariaDB4j:2.4.0',
-
+ 'org.springframework.boot:spring-boot-starter-security',
+ 'org.springframework.security.oauth.boot:spring-security-oauth2-autoconfigure:2.1.6.RELEASE',
Review comment:
We are trying to avoid specifying version numbers here.
Set the dependency and the version number in build.gradle. That way this is free of version numbers
##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TwoFactorAuthenticationFilter.java
##########
@@ -113,7 +113,7 @@ public void doFilter(ServletRequest req, ServletResponse res, FilterChain chain)
chain.doFilter(req, res);
}
- @SuppressWarnings("deprecation") // TODO FINERACT-1012
+ // FINERACT-1012
Review comment:
I think the deprecation suppression here is directly related to FINERACT-1012. Unless this resolves them somehow, I think it should remain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1114: FINERACT-1057 - Running -Psecurity=oauth leads to memory leak issue
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1114:
URL: https://github.com/apache/fineract/pull/1114#issuecomment-659525738
Conflicts on this PR. Also Travis is not passing. Seems like you are trying to fix multiple issues? Is it possible to split them into different issues and PRs? Just upgrade spring security first. If a PR had not passed Travis and contains merge conflicts, then we can't even begin to review it properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org