You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Apache Spark (Jira)" <ji...@apache.org> on 2022/10/26 12:01:00 UTC

[jira] [Commented] (SPARK-40919) Bad case of `AnalysisTest#assertAnalysisErrorClass` when `expectedMessageParameters.size between [2, 4]`

    [ https://issues.apache.org/jira/browse/SPARK-40919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624402#comment-17624402 ] 

Apache Spark commented on SPARK-40919:
--------------------------------------

User 'LuciferYang' has created a pull request for this issue:
https://github.com/apache/spark/pull/38396

> Bad case of `AnalysisTest#assertAnalysisErrorClass` when `expectedMessageParameters.size between [2, 4]`
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-40919
>                 URL: https://issues.apache.org/jira/browse/SPARK-40919
>             Project: Spark
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 3.4.0
>            Reporter: Yang Jie
>            Priority: Major
>
> If the size of the input parameter `expectedMessageParameters` of the `AnalysisTest#assertAnalysisErrorClass` method is between 2 and 4, the result of `
> e.messageParameters.sameElements(expectedMessageParameters)` is related to order.
> For example
>  
> {code:java}
> bin/scala
> Welcome to Scala 2.12.16 (OpenJDK 64-Bit Server VM, Java 1.8.0_352).
> Type in expressions for evaluation. Or try :help.
> scala> :paste
> // Entering paste mode (ctrl-D to finish)
> val messageParameters = Map(
>       "exprName" -> "`window_duration`",
>       "valueRange" -> s"(0, 9223372036854775807]",
>       "currentValue" -> "-1000000L",
>       "sqlExpr" -> "\"window(2016-01-01 01:01:01, -1000000, 1000000, 0)\""
>     )
> val expectedMessageParameters =  Map(
>       "sqlExpr" -> "\"window(2016-01-01 01:01:01, -1000000, 1000000, 0)\"",
>       "exprName" -> "`window_duration`",
>       "valueRange" -> s"(0, 9223372036854775807]",
>       "currentValue" -> "-1000000L"
>     )
> val ret = messageParameters.sameElements(expectedMessageParameters)
> // Exiting paste mode, now interpreting.
> messageParameters: scala.collection.immutable.Map[String,String] = Map(exprName -> `window_duration`, valueRange -> (0, 9223372036854775807], currentValue -> -1000000L, sqlExpr -> "window(2016-01-01 01:01:01, -1000000, 1000000, 0)")
> expectedMessageParameters: scala.collection.immutable.Map[String,String] = Map(sqlExpr -> "window(2016-01-01 01:01:01, -1000000, 1000000, 0)", exprName -> `window_duration`, valueRange -> (0, 9223372036854775807], currentValue -> -1000000L)
> ret: Boolean = false{code}
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org