[couchdb] 33/41: Speedup eunit: fabric_db_create

[da...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

davisp pushed a commit to branch speedup-test-suite
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 0365f8bb19430877c74b7f028fbfce9f1bc515b9
Author: Paul J. Davis <pa...@gmail.com>
AuthorDate: Wed Dec 25 11:40:32 2019 -0600

    Speedup eunit: fabric_db_create
---
 src/fabric/src/fabric_db_create.erl | 39 ++++++++++++++++++++++++-------------
 1 file changed, 25 insertions(+), 14 deletions(-)

diff --git a/src/fabric/src/fabric_db_create.erl b/src/fabric/src/fabric_db_create.erl
index 2edc6dc..03fabb4 100644
--- a/src/fabric/src/fabric_db_create.erl
+++ b/src/fabric/src/fabric_db_create.erl
@@ -188,30 +188,41 @@ db_exists(DbName) -> is_list(catch mem3:shards(DbName)).
 -ifdef(TEST).
 -include_lib("eunit/include/eunit.hrl").
 
-db_exists_for_existing_db_test() ->
-    start_meck_(),
+db_exists_test_() ->
+    {
+        setup,
+        fun setup_all/0,
+        fun teardown_all/1,
+        [
+            fun db_exists_for_existing_db/0,
+            fun db_exists_for_missing_db/0
+        ]
+    }.
+
+
+setup_all() ->
+    meck:new(mem3).
+
+
+teardown_all(_) ->
+    meck:unload().
+
+
+db_exists_for_existing_db() ->
     Mock = fun(DbName) when is_binary(DbName) ->
         [#shard{dbname = DbName, range = [0,100]}]
     end,
     ok = meck:expect(mem3, shards, Mock),
     ?assertEqual(true, db_exists(<<"foobar">>)),
-    ?assertEqual(true, meck:validate(mem3)),
-    stop_meck_().
+    ?assertEqual(true, meck:validate(mem3)).
+
 
-db_exists_for_missing_db_test() ->
-    start_meck_(),
+db_exists_for_missing_db() ->
     Mock = fun(DbName) ->
         erlang:error(database_does_not_exist, DbName)
     end,
     ok = meck:expect(mem3, shards, Mock),
     ?assertEqual(false, db_exists(<<"foobar">>)),
-    ?assertEqual(false, meck:validate(mem3)),
-    stop_meck_().
-
-start_meck_() ->
-    ok = meck:new(mem3).
-
-stop_meck_() ->
-    ok = meck:unload(mem3).
+    ?assertEqual(false, meck:validate(mem3)).
 
 -endif.