You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/01/18 20:58:59 UTC
[PR] RATIS-2010. Remove dependency on spotbugs-annotations [ratis]
adoroszlai opened a new pull request, #1022:
URL: https://github.com/apache/ratis/pull/1022
## What changes were proposed in this pull request?
* Remove some unnecessary `@SuppressFBWarnings`
* Remove dependency on `spotbugs-annotations`
* Remove single usage of `javax.annotation` coming from `jsr305`, which is a transitive dependency via `spotbugs-annotations`
https://issues.apache.org/jira/browse/RATIS-2010
## How was this patch tested?
```
$ mvn -DskipTests clean package
$ ./dev-support/checks/findbugs.sh
```
CI:
https://github.com/adoroszlai/ratis/actions/runs/7575711637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2010. Remove dependency on spotbugs-annotations [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1022:
URL: https://github.com/apache/ratis/pull/1022#issuecomment-1899274464
In https://github.com/apache/ratis/actions/runs/7575888844?pr=1022 , there is a warning:
```
[findbugs](https://github.com/apache/ratis/actions/runs/7575888844/job/20634123845#step:6:11)
No files were found with the provided path: target/findbugs. No artifacts will be uploaded.
```
Is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2010. Remove dependency on spotbugs-annotations [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #1022:
URL: https://github.com/apache/ratis/pull/1022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2010. Remove dependency on spotbugs-annotations [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1022:
URL: https://github.com/apache/ratis/pull/1022#issuecomment-1899884041
> In https://github.com/apache/ratis/actions/runs/7575888844?pr=1022 , there is a warning:
>
> * [findbugs](https://github.com/apache/ratis/actions/runs/7575888844/job/20634123845#step:6:11)
>
> ```
> No files were found with the provided path: target/findbugs. No artifacts will be uploaded.
> ```
>
> Is it expected?
Yes, the same also happens on `master` ([example](https://github.com/apache/ratis/actions/runs/6922173476/job/18828596492#step:6:10)). The problem is that the CI environment does not have `spotbugs` installed, so it cannot post-process the results for upload. The check still catches violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2010. Remove dependency on spotbugs-annotations [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1022:
URL: https://github.com/apache/ratis/pull/1022#issuecomment-1899900359
Thanks @szetszwo for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org