You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/20 13:10:51 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5528: test: fix test_configdrive.py and move it to smoke test

DaanHoogland commented on a change in pull request #5528:
URL: https://github.com/apache/cloudstack/pull/5528#discussion_r772350590



##########
File path: test/integration/smoke/test_configdrive.py
##########
@@ -1089,10 +1090,8 @@ def update_and_validate_sshkeypair(self, vm, public_ip=None):
 
         vm.details = vm_new_ssh.details
 
-        # reset SSH key also resets the password.
-        self._decrypt_password(vm)
-
-        vm.password_test = ConfigDriveUtils.PasswordTest(vm=vm)
+        # reset SSH key also remove the password (see https://github.com/apache/cloudstack/pull/4819)

Review comment:
       ```suggestion
           # reset SSH key also removes the password (see https://github.com/apache/cloudstack/pull/4819)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org