You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2017/04/19 17:21:38 UTC
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6686
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Revert "Pass build type to Impala LZO."
This reverts commit 2598e3b26449a03011ab419a4cc1171cee249427.
Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/6686/1
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
......................................................................
Patch Set 4:
Correct, Dan. This is a workaround. Real problem is probably still lurking in the code.
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
......................................................................
Patch Set 4: Code-Review+2
Just to be clear, this is just a workaround until we fix the real problem, right?
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change.
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Patch Set 3:
(1 comment)
Updated the change to pass DEBUG to LZO. My local tests show this working fine.
http://gerrit.cloudera.org:8080/#/c/6686/1/CMakeLists.txt
File CMakeLists.txt:
Line 390: COMMAND $ENV{IMPALA_LZO}/build.sh DEBUG ${CMAKE_SOURCE_DIR}
> Joe is going to try this and post a new patch.
Switching to passing DEBUG works on my setup.
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6686
to look at the new patch set (#2).
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Revert "Pass build type to Impala LZO."
This reverts commit 2598e3b26449a03011ab419a4cc1171cee249427.
Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/6686/2
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/471/
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Patch Set 1:
This commit lead to IMPALA-5172. Let's revert to unblock the builds.
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/470/
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
......................................................................
IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
This changes CMakeLists.txt to pass the DEBUG build type
to LZO. This effectively reverts commit
2598e3b26449a03011ab419a4cc1171cee249427.
Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Reviewed-on: http://gerrit.cloudera.org:8080/6686
Reviewed-by: Alex Behm <al...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6686
to look at the new patch set (#3).
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Revert "Pass build type to Impala LZO."
This changes CMakeLists.txt to pass the DEBUG build type
to LZO. This effectively reverts commit
2598e3b26449a03011ab419a4cc1171cee249427.
Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/6686/3
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/469/
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6686
to look at the new patch set (#4).
Change subject: IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
......................................................................
IMPALA-5172: Always pass DEBUG build type to Impala-Lzo
This changes CMakeLists.txt to pass the DEBUG build type
to LZO. This effectively reverts commit
2598e3b26449a03011ab419a4cc1171cee249427.
Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/6686/4
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6686/1/CMakeLists.txt
File CMakeLists.txt:
Line 390: COMMAND $ENV{IMPALA_LZO}/build.sh ${CMAKE_SOURCE_DIR} $ENV{IMPALA_TOOLCHAIN}
rather than reverting both changes, how about just passing "Debug" here?
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "Pass build type to Impala LZO."
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Revert "Pass build type to Impala LZO."
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6686/1/CMakeLists.txt
File CMakeLists.txt:
Line 390: COMMAND $ENV{IMPALA_LZO}/build.sh ${CMAKE_SOURCE_DIR} $ENV{IMPALA_TOOLCHAIN}
> rather than reverting both changes, how about just passing "Debug" here?
Joe is going to try this and post a new patch.
--
To view, visit http://gerrit.cloudera.org:8080/6686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: Yes