You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "aweisberg (via GitHub)" <gi...@apache.org> on 2025/08/15 21:04:27 UTC

[PR] 20841 Fix TxnData.without and simulator thread id determinism [cassandra]

aweisberg opened a new pull request, #4318:
URL: https://github.com/apache/cassandra/pull/4318

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] 20841 Fix TxnData.without and simulator thread id determinism [cassandra]

Posted by "aweisberg (via GitHub)" <gi...@apache.org>.
aweisberg closed pull request #4318: 20841 Fix TxnData.without and simulator thread id determinism
URL: https://github.com/apache/cassandra/pull/4318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] 20841 Fix TxnData.without and simulator thread id determinism [cassandra]

Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #4318:
URL: https://github.com/apache/cassandra/pull/4318#discussion_r2289359747


##########
test/simulator/test/org/apache/cassandra/simulator/test/ShortPaxosSimulationTest.java:
##########
@@ -114,7 +112,9 @@ public void selfReconcileTest()
                                                                           "-c", "2",
                                                                           "--cluster-action-limit", "2",
                                                                           "-s", "30",
-                                                                          "--with-self" });
+                                                                          "--with-self",
+                                                                          "--with-rng", "0",

Review Comment:
   why this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] 20841 Fix TxnData.without and simulator thread id determinism [cassandra]

Posted by "aweisberg (via GitHub)" <gi...@apache.org>.
aweisberg commented on code in PR #4318:
URL: https://github.com/apache/cassandra/pull/4318#discussion_r2291682076


##########
test/simulator/test/org/apache/cassandra/simulator/test/ShortPaxosSimulationTest.java:
##########
@@ -114,7 +112,9 @@ public void selfReconcileTest()
                                                                           "-c", "2",
                                                                           "--cluster-action-limit", "2",
                                                                           "-s", "30",
-                                                                          "--with-self" });
+                                                                          "--with-self",
+                                                                          "--with-rng", "0",

Review Comment:
   It enables additional validation points where threads wait to check the simulation hasn't diverged. Specifically time and random number generation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org