You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "centurysys (via GitHub)" <gi...@apache.org> on 2023/02/12 06:19:03 UTC

[GitHub] [nuttx] centurysys commented on a diff in pull request #8510: arm: Toolchain.defs: fix reverse condition for attaching libm.

centurysys commented on code in PR #8510:
URL: https://github.com/apache/nuttx/pull/8510#discussion_r1103742503


##########
arch/arm/src/common/Toolchain.defs:
##########
@@ -316,7 +316,7 @@ endif
 
 EXTRA_LIBS += $(COMPILER_RT_LIB)
 
-ifneq ($(CONFIG_LIBM),y)
+ifeq ($(CONFIG_LIBM),y)
   EXTRA_LIBS += $(wildcard $(shell $(CC) $(ARCHCPUFLAGS) --print-file-name=libm.a))

Review Comment:
   It is indeed confusing, I was having trouble with quickjs builds failing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org