You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/11/18 02:28:18 UTC
Review Request 40422: GEODE-438: fix race in off-heap memory monitor
event delivery
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40422/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-438
https://issues.apache.org/jira/browse/GEODE-438
Repository: geode
Description
-------
Fix race if OffHeapMemoryMonitor.updateMemoryUsed.
Also fixed tests to use standard locators for connectivity instead of an mcast-port.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/OffHeapMemoryMonitor.java 721e9a6cc3c839ebf958151c29a530df49b8f564
gemfire-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java a6f24d0125a50b8c8189cddc709d6ba3ffd823e7
Diff: https://reviews.apache.org/r/40422/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 40422: GEODE-438: fix race in off-heap memory
monitor event delivery
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40422/#review107053
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Nov. 18, 2015, 1:28 a.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40422/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 1:28 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-438
> https://issues.apache.org/jira/browse/GEODE-438
>
>
> Repository: geode
>
>
> Description
> -------
>
> Fix race if OffHeapMemoryMonitor.updateMemoryUsed.
> Also fixed tests to use standard locators for connectivity instead of an mcast-port.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/OffHeapMemoryMonitor.java 721e9a6cc3c839ebf958151c29a530df49b8f564
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java a6f24d0125a50b8c8189cddc709d6ba3ffd823e7
>
> Diff: https://reviews.apache.org/r/40422/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>