You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2013/12/05 03:39:55 UTC
Review Request 16033: SAMZA-94
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16033/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
failing on null writes in all serde methods.
Diffs
-----
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 53a5cbeddcee61c05beb9c858eb81d11a1cd5d93
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 2e5f6a3fe8db96fcbb409619b4890ac5359f6d17
Diff: https://reviews.apache.org/r/16033/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 16033: SAMZA-94
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16033/#review29818
-----------------------------------------------------------
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala
<https://reviews.apache.org/r/16033/#comment57299>
Return type would be nice for readability.
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
<https://reviews.apache.org/r/16033/#comment57300>
Might as well make this a generic utility and throw it in a test utils class
def expect[T](exception: Class[T])(block: => Unit)
This will let you do
expect(classOf[MyException]) {
// some code goes here
}
- Jay Kreps
On Dec. 5, 2013, 2:39 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16033/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2013, 2:39 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> failing on null writes in all serde methods.
>
>
> Diffs
> -----
>
> samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 53a5cbeddcee61c05beb9c858eb81d11a1cd5d93
> samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 2e5f6a3fe8db96fcbb409619b4890ac5359f6d17
>
> Diff: https://reviews.apache.org/r/16033/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 16033: SAMZA-94
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16033/#review30031
-----------------------------------------------------------
Ship it!
Ship It!
- Jay Kreps
On Dec. 9, 2013, 7:15 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16033/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2013, 7:15 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> throw exception when null is used for key or value in key value store.
>
>
> Diffs
> -----
>
> build.gradle 556a0a3d77b24c9360dec51cfe9be228f9bcb50f
> samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueStore.java 49089dfca6109b90bed881cd01534bce1e20a6bf
> samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 53a5cbeddcee61c05beb9c858eb81d11a1cd5d93
> samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 2e5f6a3fe8db96fcbb409619b4890ac5359f6d17
> samza-test/src/main/scala/org/apache/samza/util/TestUtil.scala PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16033/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 16033: SAMZA-94
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16033/
-----------------------------------------------------------
(Updated Dec. 9, 2013, 7:15 p.m.)
Review request for samza.
Repository: samza
Description (updated)
-------
throw exception when null is used for key or value in key value store.
Diffs (updated)
-----
build.gradle 556a0a3d77b24c9360dec51cfe9be228f9bcb50f
samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueStore.java 49089dfca6109b90bed881cd01534bce1e20a6bf
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 53a5cbeddcee61c05beb9c858eb81d11a1cd5d93
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 2e5f6a3fe8db96fcbb409619b4890ac5359f6d17
samza-test/src/main/scala/org/apache/samza/util/TestUtil.scala PRE-CREATION
Diff: https://reviews.apache.org/r/16033/diff/
Testing
-------
Thanks,
Chris Riccomini