[jira] [Commented] (MCOMPILER-464) Can't extract module name

["Naman Nigam (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCOMPILER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347688#comment-17347688 ] 

Naman Nigam commented on MCOMPILER-464:
---------------------------------------

That's not a compiler plugin issue. Even if you were to execute `--describe-module` with JDK's `jar` tool for each of these artifacts individually, you would find the same error. It's just the way that the automatic module names are derived by Java and the compiler plugin on top of it is doing its part correctly so far. 
I believe this can be closed as Not An Issue in this tracker.

> Can't extract module name
> -------------------------
>
>                 Key: MCOMPILER-464
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-464
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>    Affects Versions: 3.8.1
>         Environment: N/R
>            Reporter: Adrian Herscu
>            Priority: Critical
>
>  While trying to upgrade to JDK 11+ I am getting this :(
> Also opened issue to one of module owners:
> [https://github.com/mrwilson/java-8-matchers/issues/20]
> (will add the rest here)
> Just thinking that the "right" solution would be to allow overriding the module name via the pom.xml – perhaps there is such an option? Maybe something not documented yet?
> {{[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ my-module ---}}
> {{[WARNING] Can't extract module name from json-path-assert-2.5.0.jar: json.path.assert: Invalid module name: 'assert' is not a Java identifier}}
> {{[WARNING] Can't extract module name from xalan-2.7.2.jar: Provider class org.apache.bsf.BSFManager not in module}}
> {{[WARNING] Can't extract module name from java-8-matchers-1.9.jar: java.8.matchers: Invalid module name: '8' is not a Java identifier
> [INFO] Changes detected - recompiling the module!}}
> {{[INFO] -------------------------------------------------------------
> [ERROR] COMPILATION ERROR : 
> [INFO] -------------------------------------------------------------}}
> {{[ERROR] module not found: org.openqa.selenium.core}}
> {{[ERROR] module not found: httpcore}}
> {{[ERROR] module not found: httpclient}}
> {{[INFO] 3 errors }}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)