[GitHub] [lucene-solr] samuelgmartinez commented on pull request #1480: SOLR-14456: Fix Content-Type header forwarding on compressed requests

[GitBox <gi...@apache.org>]

samuelgmartinez commented on pull request #1480:
URL: https://github.com/apache/lucene-solr/pull/1480#issuecomment-623599049


   > I think this issue should exist in `Http2SolrClient`, I see similar logic there. That was just a cursory look though.
   
   I reviewed it and it's now properly implemented. It relies on two different methods for getting the encoding: one is Jetty's `Response.CompleteListener#getEncoding` (which is the charset not the content-encoding) and then the `Http2SolrClient#getEncoding` (which relies on a "manual" parsing of the charset attribute from the content-type header).
   
   I think I should refactor `Http2SolrClient#getEncoding` to just get the encoding using the HttpClient's `ContentType` classes. I don't think it's perfect as the http2 Jetty based implementation would depend on a HttpClient class, but the dependency [is there already](https://github.com/apache/lucene-solr/blob/13f19f65559290a860df84fa1b5ac2db903b27ec/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java#L686). Any opinion on the refactor? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org