You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Frank Bille Jensen (JIRA)" <ji...@apache.org> on 2006/10/24 07:41:17 UTC

[jira] Commented: (WICKET-15) EnterAlwaysSubmits and RetrainFormFocus behaviors

    [ http://issues.apache.org/jira/browse/WICKET-15?page=comments#action_12444199 ] 
            
Frank Bille Jensen commented on WICKET-15:
------------------------------------------

Thank you for providing these files. Just a few comments after having looked through the files quickly:

I think that the dependency on the wicket-ajax.js file is perhaps a little overkill because as far as I can see you only use the wicketKeyCode() method from it (which itself is about 6 lines). 
Even though I really like the idea of what you are doing IMHO they don't belong in core but in extensions. You'r patch doesn't change anything in core but only extends whats already there (which is a good thing).

> EnterAlwaysSubmits and RetrainFormFocus behaviors
> -------------------------------------------------
>
>                 Key: WICKET-15
>                 URL: http://issues.apache.org/jira/browse/WICKET-15
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.2.2
>            Reporter: Gili
>         Attachments: EnterAlwaysSubmits.java, form.js, RetainFormFocus.java
>
>
> I'd like to contribute two new behaviors to wicket-core:
> 1) EnterAlwaysSubmits - Allows forms with multiple text fields to submit using ENTER. By default HTML will only allow the use of ENTER if there is at most one text field.
> 2) RetainFormFocus - Ensures that the field that submitted the form retains the focus once the page reloads

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira