[jira] [Commented] (TAP5-2450) Changes for TAP5-2445 broke AbstractConditional components

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313845#comment-14313845 ] 

Hudson commented on TAP5-2450:
------------------------------

FAILURE: Integrated in tapestry-trunk-freestyle #1380 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1380/])
TAP5-2450, TAP5-2445: Reset the renderTag field in the AfterRender phase, fixes state leak when using an AbstractConditional within a Loop (jochen.kemnade: rev 69a689d45055c1c4fae7a1fcf53422052cfca890)
* tapestry-core/src/test/resources/org/apache/tapestry5/integration/app2/pages/TestPageForIf.tml
* tapestry-core/src/test/java/org/apache/tapestry5/integration/pagelevel/IfTest.java
* tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractConditional.java


> Changes for TAP5-2445 broke AbstractConditional components
> ----------------------------------------------------------
>
>                 Key: TAP5-2450
>                 URL: https://issues.apache.org/jira/browse/TAP5-2450
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Sven Homburg
>            Assignee: Jochen Kemnade
>              Labels: regression
>             Fix For: 5.4
>
>         Attachments: sts-intranet.log
>
>
> since michaels performance changes , the if component dont work as in the past like the bottom example.
> {code:title=Page.java}
> @Component(parameters = {"test=condition"}
> private If ifSomethingWrong
> {code}
> {code:title=Page.tml}
> <span t:id="ifSomethingWrong">
>   blabla
> </span>
> {code}
> if i use this code, tapestry throws an exception means markup is unbalanced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)